[HOLD - #374470] Thread header and LHN for task assignee system message is missing the assignee

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.49-0
Reproducible in staging?: y
Reproducible in production?: NO - new feature (system message)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to any chat.
Create a task.
Go to task report.
Click Assignee.
Add an assignee (or change assignee).
Right click on assignee system message > Reply in thread.

Expected Result:

The thread header and LHN title will show assignee name.

Actual Result:

The thread header and LHN title do not show assignee name.

Also, The email in system message is also not copied when copied to clipboard.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6406286_1709856534747.bandicam_2024-03-08_08-05-59-267.mp4

View all open jobs on GitHub

@strepanier03

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@marcaaron

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@marcaaron

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@quinthar

We think this bug might be related to #vip-vsb. cc @quinthar

Proposal

 ### Please re-state the problem that we are trying to solve in this issue.
Thread header and LHN for task assignee system message is missing the assignee

What is the root cause of that problem?

The message in parentReportAction says something like this: assigned to <mention-user accountID=16485686></mention-user> and the final message only remains 'assigned to' on both header and and LHN.

App/src/libs/ReportUtils.ts

Lines 2616 to 2620 in 9132e05

    
           const parentReportActionMessage = ( 
        
               ReportActionsUtils.isApprovedOrSubmittedReportAction(parentReportAction) 
        
                   ? ReportActionsUtils.getReportActionMessageText(parentReportAction) 
        
                   : parentReportAction?.message?.[0]?.text ?? '' 
        
           ).replace(/(\r\n|\n|\r)/gm, ' ');

What changes do you think we should make in order to solve the problem?

We need to first check if message has accountId, and if it has then we get the display name for the participant.

const participantAccountId = doesMessageHasAccountId()
       if(parentReportAction.actionName === CONST.REPORT.ACTIONS.TYPE.TASKEDITED && participantAccountId) {
           parentReportActionMessage = parentReportActionMessage + ' ' + + getDisplayNameForParticipant(participantAccountId, undefined, undefined, true);
        }
       return parentReportActionMessage;

Here doesMessageHasAccountId() is simple utility function which will check if message has accountId and it has then it will return that accountId. Also in above condition CONST.REPORT.ACTIONS.TYPE.TASKEDITED represents that task is edited and we are opening that (edited) system message

What alternative solutions did you explore? (Optional)

Result

I am thinking if this is a new feature then we probably don't need to make this a blocker.

Not prioritized currently.

Updating project as VSB was closed.

Navigation Menu

Repository navigation

[HOLD - #374470] Thread header and LHN for task assignee system message is missing the assignee #37939

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const parentReportActionMessage = (
	ReportActionsUtils.isApprovedOrSubmittedReportAction(parentReportAction)
	? ReportActionsUtils.getReportActionMessageText(parentReportAction)
	: parentReportAction?.message?.[0]?.text ?? ''
	).replace(/(\r\n\|\n\|\r)/gm, ' ');

[HOLD - #374470] Thread header and LHN for task assignee system message is missing the assignee #37939

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 8, 2024

github-actions commented on Mar 8, 2024

melvin-bot commented on Mar 8, 2024

kavimuru commented on Mar 8, 2024

kavimuru commented on Mar 8, 2024

nexarvo commented on Mar 8, 2024

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

marcaaron commented on Mar 8, 2024

48 remaining items

strepanier03 commented on Sep 3, 2024

strepanier03 commented on Oct 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions