Repository navigation
Join request - Accept and Decline button from Join request does not work in thread #37964
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating PR : #37525
Version Number: 1.4.49-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
-
The invite link to workspace is https://staging.new.expensify.com/workspace/<Workspace_ID>/join?email=<admin_email>
-
Non-member has clicked on the link to join the workspace.
- Go to staging.new.expensify.com as non-member.
- Go to #admin of the workspace from precondition.
- Right click on join request message > Reply in thread,
- Click Accept or Decline.
Expected Result:
Accept and Decline button works in thread.
Actual Result:
Accept and Decline button does not work in thread.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Mar 8, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 8, 2024
Triggered auto assignment to @rlinoz (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 8, 2024
@rlinoz I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 8, 2024
We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney
narefyev91 commentedon Mar 8, 2024
Will pick this one - in case it related to Invite member PR - i think we need to disable ability to make a thread for Accept/Reject requests. Same as we have for whisper option
rlinoz commentedon Mar 8, 2024
Hmm I can't reproduce the issue, it takes a while to get accepted, but it works.
Screen.Recording.2024-03-08.at.09.13.29.mov
rlinoz commentedon Mar 8, 2024
I think this is a different case where it is important to allow admins to start a thread out of a request to join the workspace
narefyev91 commentedon Mar 8, 2024
Works for me on latest main
Screen.Recording.2024-03-08.at.14.18.38.mov
rlinoz commentedon Mar 8, 2024
Yeah, I am testing in staging and it works as well
Screen.Recording.2024-03-08.at.09.19.11.mov
rlinoz commentedon Mar 8, 2024
@narefyev91 correct me if I am wrong, but there is also no way to create the invite link in product right now, right?
narefyev91 commentedon Mar 8, 2024
Yup you are right
rlinoz commentedon Mar 8, 2024
Great, that makes this a non blocker
rlinoz commentedon Mar 11, 2024
Tested again today, still can't reproduce, so closing this one.