Skip to content

[$1000] Web - Workspace - No loading indicator is shown on WS screen when navigating via invite link #37959

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.49-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37525
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions:

  1. Has a workspace (new or existing one)
  2. Prepare join url link - use WorkspaceID and admin email for that workspace - ex. https://staging.new.expensify.com/workspace/7DE6960B26D79E36/join?email=tenema5675@bizatop.com
    For user:
  3. Open link in a new tab (for a new user / or user which already logged in)

The expected behaviour of OP (online case) is:

  • Never show loading indicator
  • Invited workspace item is immediately shown (loading, success cases)
  • If fails, gray out with RBR (failure case)

Expected Result:

A loading indicator should be shown

Actual Result:

No loading indicator is shown on all Workspace screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6406682_1709887302660.NoLoadingBug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e403ef173151cba4
  • Upwork Job ID: 1766065429321519104
  • Last Price Increase: 2024-04-23

Activity

  1. github-actions commented on Mar 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 8, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Mar 8, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave8-collect-admins
    CC @zanyrenney

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 8, 2024
  5. 61 remaining items

  6. melvin-bot commented on Apr 12, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  7. melvin-bot commented on Apr 16, 2024

    @melvin-bot

    @mananjadhav, @Julesssss Huh... This is 4 days overdue. Who can take care of this?

  8. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    @mananjadhav, @Julesssss Still overdue 6 days?! Let's take care of this!

  9. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  10. melvin-bot commented on Apr 22, 2024

    @melvin-bot

    @mananjadhav, @Julesssss 10 days overdue. Is anyone even seeing these? Hello?

  11. Julesssss commented on Apr 23, 2024

    @Julesssss
    Contributor

    I'm going to bump to $1000 as nobody has commented in a month

  12. changed the title [-][$500] Web - Workspace - No loading indicator is shown on WS screen when navigating via invite link[/-] [+][$1000] Web - Workspace - No loading indicator is shown on WS screen when navigating via invite link[/+] on Apr 23, 2024
  13. melvin-bot commented on Apr 23, 2024

    @melvin-bot

    Upwork job price has been updated to $1000

  14. brandonhenry commented on Apr 23, 2024

    @brandonhenry
    Contributor

    any feedback on my proposal? I have accurate root cause and solution: #37959 (comment)

    Cc. @Julesssss @mananjadhav @mkhutornyi

  15. Julesssss commented on Apr 24, 2024

    @Julesssss
    Contributor

    Hey @brandonhenry. Looking back I think this was the last comment about your proposal.

  16. Julesssss commented on Apr 24, 2024

    @Julesssss
    Contributor

    Anyway, after retesting I believe the current behaviour is desired, and this issue can be closed. We're matching this expected behaviour:

    test1.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions