[saphid]

Problem

When Antigravity is the text generation model, commit messages, PR text, branch names and thread titles failed with only "Antigravity text generation failed." That happened even when T3 knew exactly what was wrong:

• T3's own setup errors were hidden. If a sign-in or sign-out is still running, or the Antigravity settings are incomplete, T3 refuses to start the helper with a clear message (for example "Antigravity sign-in or sign-out is in progress. Try again after it finishes."). The user only saw the generic failure.
• A signed-out Antigravity agent rejects the request with the ACP "auth required" error (JSON-RPC code -32000). The user saw the generic failure, not a prompt to sign in.

Change

The fallback error mapper in AntigravityTextGeneration.ts now picks a fixed detail from structured signals:

• ProviderSetupError: its detail passes through. All of these on this path are T3-authored fixed text, or text built from structured attributes. The shared provider-core failure helper already treats them as curated.
• ACP sign-in required (the existing isAntigravitySignInRequiredError: code -32000, or T3's blocked-login transport error): the existing fixed text "Sign in to Antigravity in Settings before you continue."
• Anything else: the generic "Antigravity text generation failed."

The agent's own message stays only in the error's cause. It is never copied into detail. This follows docs/internals/effect-services.md "Errors": messages are fixed or built from structured attributes, never from raw provider text. Usage limits are not mapped. At this call site Antigravity reports them only as message text, not as a structured code.

Scope and approval

Very small, focused fix for an obvious bug, so no prior issue: about 10 non-test lines in one file. One existing test became a two-row table (sign-in code and an unknown code). The existing sign-in admission test gained one assertion.

Overlap search: the local PR index, plus gh searches for "Antigravity text generation" and Antigravity AcpRequestError. Closest: #29548 (ACP sign-in failure wording in provider-core/failure.ts) and #21419 (Antigravity sign-in feedback in AntigravityAuth.ts). Neither touches text generation. #29800 (Grok), #29748 (Cursor) and #29805 (Codex) are sibling fixes for other providers.

Verification

• Red on the previous head (which copied the agent's message into detail): AssertionError: expected 'Antigravity text generation failed: R…' to be 'Sign in to Antigravity in Settings be…'. The unknown-code row also failed: expected 'Antigravity text generation failed: R…' to be 'Antigravity text generation failed.'
• The test also asserts that the raw provider text does not appear in detail.
• Green: vp test run src/textGeneration/AntigravityTextGeneration.test.ts passes 34 of 34.
• vp run check:changed: format, lint, knip, graphql, typecheck (3 packages) and tests (2 files) all pass.
• Not checked: a live Antigravity agent returning a prompt error, or a live signed-out Antigravity. The tests inject the errors at the runtime boundary.

Reviewed with sol-loop: 3 rounds with GPT-6.1 Sol on high (one per commit). Sol verdict: approved.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 8c82528

Macroscope's review found this PR approvable — Antigravity text generation now shows actionable setup and sign-in errors instead of a generic failure. The change is limited to error feedback and leaves authentication behavior, product defaults and data handling unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Antigravity text generation now selects provider setup details or a fixed sign-in-required detail for recognized errors. Other errors retain the generic detail. Tests verify fixed details for selected ACP prompt error codes, ensure raw provider text is excluded, and check the sign-in admission detail.

Changes: Antigravity error details

Layer / File(s)	Summary
Map Antigravity error details apps/server/src/textGeneration/AntigravityTextGeneration.ts, apps/server/src/textGeneration/AntigravityTextGeneration.test.ts	The error handler uses ProviderSetupError.detail for provider setup errors and a sign-in-required detail for recognized sign-in errors. Other errors use the generic detail. Tests check fixed details for ACP prompt errors -32000 and -32603, verify raw provider text is excluded, clean up fixtures, and assert the sign-in admission detail.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#29800: This PR applies analogous fixed ACP error-detail mapping to Grok text generation.

Suggested labels: bugfix

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 8c825

The reviewed error mapping has no established remaining merge-blocking defect.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Linked Issues check		Directly linked issue #29800 is open. Its coding requirements apply to this PR. It requires Grok text generation to map ACP JSON-RPC error codes to fixed details: -32003 gives "Grok usage limit reache…	Choose one remediation. (a) Add the Grok change to this PR. In the Grok text-generation error mapping, map ACP error codes -32003, -32000, and (for model switching only) -32602 to the fixed details in the #29800 table. Keep all other errors…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title names the Antigravity text generation area and the change of surfacing sign-in and setup errors. The raw summary confirms the change maps ProviderSetupError details and ACP sign-in-required …
Description check		The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section explains the expected behavior and the observed generic fail…
Out of Scope Changes check		The whole-PR diff changes one source file and its test file. In AntigravityTextGeneration.ts, the diff makes three changes. It changes the ProviderSetupError import from type-only to a value import so…

Full details: Title check

Explanation

The title names the Antigravity text generation area and the change of surfacing sign-in and setup errors. The raw summary confirms the change maps ProviderSetupError details and ACP sign-in-required errors to user-facing text. The title is specific, concise, and follows the conventional commit form. It does not mention the fixed generic fallback or that raw agent text is kept out of detail, but the main change is clearly covered.

Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section explains the expected behavior and the observed generic failure. The Change section explains the error mapping and cites the relevant docs rule. The Scope section explains why no prior issue exists and lists overlapping PRs. The Verification section lists the focused test run, the red-then-green result, the check run, and what was not checked. One gap: the Scope section justifies the small-fix exemption, which is acceptable, but the template's approval requirement for a very small obvious bug is met by the stated explanation. The description is mostly complete.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes one source file and its test file. In AntigravityTextGeneration.ts, the diff makes three changes. It changes the ProviderSetupError import from type-only to a value import so Schema.is can test it. It adds the isProviderSetupError guard. It sets the TextGenerationError detail to cause.detail for ProviderSetupError, to ANTIGRAVITY_SIGN_IN_REQUIRED_MESSAGE for isAntigravitySignInRequiredError matches, and otherwise keeps "Antigravity text generation failed.". The agent message stays only in cause. This directly implements the bug described in the PR description. The PR does not link an Antigravity issue, so its own description defines its scope. No change in the diff touches Grok or another provider. The test changes support the same behavior. The thematic overlap with #29800 does not make the Antigravity change unrelated. I did not inspect the provider-core helper that treats ProviderSetupError details as curated. That point rests on the PR description.

Full details: Linked Issues check

Explanation

Directly linked issue #29800 is open. Its coding requirements apply to this PR. It requires Grok text generation to map ACP JSON-RPC error codes to fixed details: -32003 gives "Grok usage limit reached. Try again later.", -32000 gives "Grok authentication is required.", and -32602 in the model switch gives "Grok rejected the text generation model settings.". Other errors keep the generic Grok detail. Raw provider text must stay only in cause. The whole-PR diff (merge base f6503f0 to head 8c82528) changes only apps/server/src/textGeneration/AntigravityTextGeneration.ts and AntigravityTextGeneration.test.ts. It changes no Grok file. The head file list for apps/server/src/textGeneration contains GrokTextGeneration.test.ts but no Grok implementation file, and this PR does not touch Grok. The PR objectives call the Grok issue context only. That conflicts with the link type. A direct link keeps #29800 as a primary requirement. Its Grok requirements are therefore unmet by this PR. The Antigravity change does not satisfy them. The earlier remediation (append the raw ACP message to the detail) no longer matches the current issue text, which requires fixed details.

Resolution

Choose one remediation. (a) Add the Grok change to this PR. In the Grok text-generation error mapping, map ACP error codes -32003, -32000, and (for model switching only) -32602 to the fixed details in the #29800 table. Keep all other errors on the generic Grok detail. Keep the raw provider text only in cause. Add tests for each code and for the model-switch case. The detail must be asserted exactly, and the test must show that raw provider text is absent from detail. (b) If this PR stays Antigravity-only, change the link to #29800 from direct to contextual or sibling context. Then the #29800 coding requirements no longer apply to this PR. Confirm the link change before the next assessment.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/typescript/security/jwt-weak-encryption-typescript.yml

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 2
• Charged: $0.50
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: f6503f0
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: d00a124e-2bbb-4900-bca1-4d8b4e1a1078

Commits

Reviewing files that changed from the base of the PR and between a87d9a9 and 8c82528.

Files selected for processing: 2

• apps/server/src/textGeneration/AntigravityTextGeneration.test.ts
• apps/server/src/textGeneration/AntigravityTextGeneration.ts

Limit details: You’ve used all 10 included reviews currently available.

[coderabbitai]

• Fix comments: Fix CodeRabbit comments on this PR

Dismissing prior approval to re-evaluate a87d9a9

[saphid]

Note

🤖 Claude Opus 5.5 responding on behalf of saphid

Reworked this PR to follow the documented error rule in docs/internals/effect-services.md "Errors". The agent's raw message is no longer copied into TextGenerationError.detail. It stays only in cause.

Mapped categories:

• ProviderSetupError (T3's own fixed setup and sign-in admission text): its detail passes through unchanged.
• ACP sign-in required (-32000, via the existing isAntigravitySignInRequiredError): "Sign in to Antigravity in Settings before you continue."
• Any other failure: "Antigravity text generation failed."

Commit: 8c82528

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

Verified unchanged head 8c8252834c7bec72a21d8c171a1389e94cc20589 against github/main at 61c3794c32b0eeebfac09add43e403618c65d2d7 on Linux. Installed both with vp i and ran their real dev servers sequentially with isolated state. Drove the web client using repository Playwright and /usr/bin/google-chrome. No mocks or fixtures.

Added a real git repository through the app and used a real Codex gpt-6.1-sol turn to create an uncommitted README. Added Antigravity through provider settings with Gemini API key authentication and no key. Selected its text generation model using the running server's authenticated server.updateSettings WebSocket API.

Clicking Commit on main showed only Antigravity text generation failed. The server's error cause already contained Enter a Gemini API key in the Antigravity provider settings. On this PR, the same action with the same thread and README showed that exact setup instruction.

Switched to Google account authentication and installed managed Antigravity 1.4.5 through Settings. Clicking Commit while signed out showed Sign in to Antigravity in Settings before you continue. The recording shows the actual request and resulting error. Failed generation left the README uncommitted.

Neighbor checks passed: a real Codex gpt-6.1-sol follow-up read the README and returned its heading; switching text generation back to Codex and clicking Commit created 2c12c7d docs: describe text generation setup verification, leaving a clean working tree. The missing-runtime Antigravity setup instruction also reached the client before installation.

Blacksmith passed the 34 focused Antigravity tests and vp run check:changed f6503f0e717f5d577a897149b4ceeb3d1bf00b3a: format, lint, knip, GraphQL generation check, typechecks, and 35 tests. GitHub's final check rollup had no failures or pending runs; some jobs were skipped and an earlier native fingerprint run was cancelled alongside a successful run. No source changes or pushes were needed.

Short runtime transcript

Not verified

Signed-in Antigravity success needs a Google account or API credential, neither provided here. Did not force a real unknown ACP error or race a sign-in/sign-out operation. PR text, branch-name and title failure entry points were not exercised individually. Electron shell, native mobile, other operating systems, and relay/tunnel connections were not exercised on this Linux web setup.