Skip to content

fix(mobile): align settled and active thread rows - #26622

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
PixPMusic:fix/mobile-thread-row-alignment-1
Oct 28, 2026
Merged

juliusmarminge merged 1 commit into
pingdotgg:mainfrom
PixPMusic:fix/mobile-thread-row-alignment-1

Conversation

@PixPMusic

Copy link
Copy Markdown
Contributor

Problem

Settled and snoozed thread rows sit farther inward than active rows on Android, and their larger icon-to-title gap misaligns titles on both native platforms.

Change

Use the existing platform-specific row padding for compact rows and match the active row's icon-to-title spacing. This covers the mobile home list and navigation sidebar while preserving compact row heights.

Scope and approval

Alex reported the misalignment and requested this focused fix. It corrects an obvious spacing defect in the existing mobile thread list and qualifies for the small bug-fix exception. Web/desktop, providers, contracts, and connection behavior need no changes.

Verification

  • vp run check:changed passed formatting, lint, both knip checks, and affected mobile/scripts typechecks.
  • Matched native before/after captures on Pixel 10 Pro (Android 15, dark), iPhone 18 Pro (iOS 27.0, dark), and iPad Pro 13-inch (iPadOS 27.0, light/sidebar). Each pair uses the same device, orientation, theme, search, and isolated demo data. Android reproduces the extra compact-row inset; all three show the corrected title spacing.
  • Before is base 9e09926d9782; after is this PR's 45be4cfd07b1. Fixture changes and screenshots are excluded from the branch. No cosmetic UI test added. Physical devices and Android tablet layouts were not exercised.
Surface Before After
Android phone Android phone before alignment fix Android phone after alignment fix
iPhone iPhone before alignment fix iPhone after alignment fix
iPad sidebar iPad sidebar before alignment fix iPad sidebar after alignment fix

Capture revisions, native fingerprints, dimensions, and asset hashes.

Model: GPT-6.1 Sol (xhigh reasoning) | Harness: Codex in T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 45be4cf

Macroscope's review found this PR approvable — This aligns mobile thread-row spacing using the shared layout class and a smaller internal gap. The change is presentation-only and leaves thread interactions and stored data unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9e09926 and 45be4cf.

Files selected for processing: 1
  • apps/mobile/src/features/threads/thread-list-v2-items.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The slim thread row now uses a shared content class, a smaller item gap, and explicit horizontal padding only in the sidebar pane.

Changes: Thread row layout

Layer / File(s) Summary
Slim row spacing
apps/mobile/src/features/threads/thread-list-v2-items.tsx
The slim row uses THREAD_LIST_V2_ROW_CONTENT_CLASS_NAME, reduces the item gap from 2.5 to 2, and applies px-3 only in the sidebar pane. The previous non-sidebar px-5 padding is removed.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested labels: size:XS

Suggested reviewers: flamboh, juliusmarminge

Merge Risk: Minimal · up to 45be4

The reviewed spacing changes are ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Description check Passed The description includes all required sections. It explains the problem, change, scope approval, focused verification, UI evidence, limitations, and agent details.
Title check Passed The title clearly and concisely describes the primary mobile UI fix: alignment between settled and active thread rows.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit e34067e into pingdotgg:main Oct 28, 2026
29 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 29, 2026
## What's Changed
* docs(agents): agents verify in a browser or simulator without asking by @juliusmarminge in pingdotgg/t3code#26637
* feat(pull-requests): manage GitHub maintainer edits by @Bil0000 in pingdotgg/t3code#25588
* fix(web): image chips drop the pill and match other chips by @flamboh in pingdotgg/t3code#26379
* fix(mobile): align settled and active thread rows by @PixPMusic in pingdotgg/t3code#26622
* fix(server): publish local git status before remote lookup by @JustYannicc in pingdotgg/t3code#21046
* fix(server): outside MCP clients get thread links they can open by @t3dotgg in pingdotgg/t3code#26642
* fix(web): double-click selects the whole inline code span by @t3dotgg in pingdotgg/t3code#26639
* fix(acp): ID-only command approvals keep the tracked command and grant the terminal by @juliusmarminge in pingdotgg/t3code#26647
* fix(cursor): subagent ls, lint and MCP results no longer fail the parent run by @juliusmarminge in pingdotgg/t3code#26592
* perf(web): long-thread timeline rebuilds 45 → 9 ms, tool updates 12 → 0.3 ms by @juliusmarminge in pingdotgg/t3code#26727
* fix(mobile): a thread opened while reconnecting no longer turns into a new draft by @shivamhwp in pingdotgg/t3code#26565
* fix(web): keep settled drop hint inside the sidebar viewport by @Yash-Singh1 in pingdotgg/t3code#26736
* feat(devices): Simlock setup uses each machine's agent-device token, checks tokens, and lists the pool through worker reconnects by @juliusmarminge in pingdotgg/t3code#26706
* fix(web): pull request diff follows the file tree, with a hide-tests filter by @juliusmarminge in pingdotgg/t3code#26730
* fix(mobile): delivered messages no longer reappear at the bottom of long threads by @juliusmarminge in pingdotgg/t3code#26739
* ci(mobile): fork PRs now get the Native Change label by @juliusmarminge in pingdotgg/t3code#26755
* fix(claude): command approvals show the command, not Claude's description of it by @maria-rcks in pingdotgg/t3code#20145
* docs: add nixpkgs installation instructions by @0x4bs3nt in pingdotgg/t3code#26750
* feat(server,web,mobile): fall back when the default provider is out of usage by @maria-rcks in pingdotgg/t3code#26164
* fix(ci): fork PRs now resolve in workflow_run PR lookups by @juliusmarminge in pingdotgg/t3code#26779


**Full Changelog**: pingdotgg/t3code@v0.1.4-nightly.20261028.3841...v0.1.4-nightly.20261029.3853

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.4-nightly.20261029.3853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants