[shivamhwp]

Refs #21744 (the composer toolbar half shipped in #19239)

What's fixed

With Android's Remove animations setting on, Thread settings rows can stay invisible because the first frame of their fade is dropped. The rows now skip their enter and exit fades when reduced motion is on.

Evidence

Not shown: a release build of this PR. The blank rows showed on the release nightly but not in a dev client with the fix reverted.

[macroscopeapp]

Approvability

Verdict: Approved at 5825695

Macroscope's review found this PR approvable — Thread settings rows skip entering and exiting fades when reduced motion is enabled, avoiding the reported invisible-row behavior. The change is presentation-only and leaves settings, selections, and ordinary-motion behavior unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 77336a5
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6dbc7ae0-c1b7-49e8-9ac8-89b41910f6a5

Commits

Reviewing files that changed from the base of the PR and between 5825695 and 4fe69af.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 32ecd71
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0a363960-9020-4f7a-be46-10e58c8ebf31

Commits

Reviewing files that changed from the base of the PR and between d970278 and 5825695.

Files selected for processing: 1

• apps/mobile/src/features/threads/ThreadSettingsSheet.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

Thread settings now enable catalog and option animations only after the list loads and when reduced motion is disabled.

Changes: Thread settings animation behavior

Layer / File(s)	Summary
Reduced-motion animation readiness apps/mobile/src/features/threads/ThreadSettingsSheet.tsx	The component derives animation readiness from list loading and useReducedMotion(). The list-load callback now updates the list-loaded state.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: 📱 Native Change

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 58256

No actionable merge-blocking risk was identified; the change is ready for normal validation.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		The only linked issue supplied is #16080. It is closed and completed, so it is historical context only. No active directly linked target remains, so no linked-issue coding requirements apply. The PR d…
Out of Scope Changes check		The whole-PR diff from the merge base to the reviewed head changes one file: apps/mobile/src/features/threads/ThreadSettingsSheet.tsx (+11/-3). The change adds useReducedMotion from react-native-reani…
Title check		The title clearly identifies the Android Thread settings row animation fix and matches the primary change.
Description check		The description explains the Android reduced-motion problem, the fix, linked issue context, and before-and-after evidence. It does not use the template headings and does not include a recording or rel…

Full details: Linked Issues check

Explanation

The only linked issue supplied is #16080. It is closed and completed, so it is historical context only. No active directly linked target remains, so no linked-issue coding requirements apply. The PR description cites #21744, but that issue is not in the supplied linked issues, so it is not assessed as a requirement. The toolbar fix from #16080 is on main per the PR objectives. A diff from the merge base to the reviewed head shows no change to apps/mobile/src/features/voice-input/ComposerDictationControl.tsx, so this PR does not need to implement it.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff from the merge base to the reviewed head changes one file: apps/mobile/src/features/threads/ThreadSettingsSheet.tsx (+11/-3). The change adds useReducedMotion from react-native-reanimated. It sets animationsReady to listLoaded && !reducedMotion, and onLoad now sets listLoaded. This matches the current PR description, which states that Thread settings rows vanish under Android Remove animations and that the fix skips their fades when reduced motion is enabled. The earlier toolbar guard changes are no longer in the whole-PR diff. No unrelated file or behavior change is shown. No active linked issue provides a separate objective to compare against, so this judgment rests on the current PR description and the code diff.

Full details: Description check

Explanation

The description explains the Android reduced-motion problem, the fix, linked issue context, and before-and-after evidence. It does not use the template headings and does not include a recording or release-build verification, but it is mostly complete and relevant.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[juliusmarminge]

Note

Grok responding on behalf of Julius.

Heads up: the composer toolbar half of this (ComposerDictationControl) just landed on main in #19239, which also closed #16080. Could you rebase and narrow this PR to the ThreadSettingsSheet change only, and update the title and description to match?

Dismissing prior approval to re-evaluate 5825695

[shivamhwp]

@juliusmarminge Done. It's rebased on main and only changes ThreadSettingsSheet now. I updated the title and description to match and dropped the composer screenshots.

[Opus 5.5][Claude Code] on behalf of shivam.