Skip to content

fix(mobile): Android Thread settings rows no longer vanish with animations removed #21757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivamhwp merged 1 commit into from
Oct 30, 2026
+11 −3
Merged

fix(mobile): Android Thread settings rows no longer vanish with animations removed #21757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions apps/mobile/src/features/threads/ThreadSettingsSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ import {
type ReactNode,
} from "react";
import { Platform, Pressable, RefreshControl, ScrollView, TextInput, View } from "react-native";
import Animated, { FadeIn, FadeOut, LinearTransition } from "react-native-reanimated";
import Animated, {
FadeIn,
FadeOut,
LinearTransition,
useReducedMotion,
} from "react-native-reanimated";
import { useSafeAreaInsets } from "react-native-safe-area-context";

import { SymbolView } from "../../components/ui/AppSymbol";
Expand Down Expand Up @@ -938,7 +943,10 @@ function ThreadSettingsMainContent(props: {
if (error) Dialog.alert("Could not refresh models", error);
});
};
const [animationsReady, setAnimationsReady] = useState(false);
const [listLoaded, setListLoaded] = useState(false);
// Android can drop the first frame of a reduced-motion fade, leaving rows invisible.
const reducedMotion = useReducedMotion();
const animationsReady = listLoaded && !reducedMotion;
const catalogItems = buildThreadSettingsCatalogItems(session);
const hasActiveCatalogFilter =
session.providerFilter !== null || session.searchQuery.trim().length > 0;
Expand Down Expand Up @@ -1064,7 +1072,7 @@ function ThreadSettingsMainContent(props: {
<RefreshControl refreshing={isRefreshingProviders} onRefresh={refreshProviders} />
) : undefined
}
onLoad={() => setAnimationsReady(true)}
onLoad={() => setListLoaded(true)}
renderItem={renderCatalogItem}
showsVerticalScrollIndicator={false}
/>
Expand Down
Loading