Skip to content

fix(docs-hygiene): compress caveman/taxonomy audit remediations (0.15.0) - #2811

Closed
kyle-sexton wants to merge 3 commits into
mainfrom
cursor/2745-compress-audit-8f91
Closed

fix(docs-hygiene): compress caveman/taxonomy audit remediations (0.15.0)#2811
kyle-sexton wants to merge 3 commits into
mainfrom
cursor/2745-compress-audit-8f91

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Closes #2745

Summary

Replacement for #2805 (auto-closed when stack base deleted). Compress caveman/taxonomy audit remediations on top of #2810.

Related

@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 4s —— View job


Security review (/review:security-review)

  • Gather context (diff, changed files, CLAUDE.md)
  • Invoke /review:security-review skill and follow its procedure
  • Post findings / results

Scope reviewed: full diff origin/cursor/2735-route-sibling-8f91...HEAD (13 files, +313/-53) — plugins/docs-hygiene/ skill docs (SKILL.md, context/*.md), CHANGELOG.md, plugin.json version bump, evals/evals.json + new fixture, and two shell scripts (scripts/audit-scan.sh new, scripts/detect-caveman.sh modified) plus their test scripts.

No security issues found.

This PR is documentation/tooling for the docs-hygiene:compress skill — prose-compression methodology docs, eval fixtures, and local dev-tooling shell scripts. It has no security-relevant surface:

  • No GitHub Actions workflow files are touched (no permissions:, triggers, or CI changes).
  • No authentication, authorization, secrets, tokens, or network I/O are involved.
  • The two shell scripts (audit-scan.sh, detect-caveman.sh) operate only on local file paths supplied by the invoking session/skill (the same trust boundary as the user's own repo) — no eval, no unsanitized interpolation into a shell context, filenames handled via quoted arrays/variables throughout. detect-caveman.sh's jq usage takes JSON via a shell variable (printf '%s' "$json" | jq ...), not string-interpolated into the jq filter itself, so it's not injectable.
  • SKILL.md's revised Step B (temp-dir mechanical-compression backend) still confines writes to a mktemp -d tempdir and only copies back over the real target on explicit success — same safety property as before, just restructured for the "Bash state doesn't persist across tool calls" constraint.

Per the security-review skill's high-signal bar, no pre-existing/style/lint findings are reported here — see /review:code-review for that lane.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

Last security-reviewed head: afe41531fca7d8ab6cef6e20eb33853b9df4732d. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49588fefcf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/docs-hygiene/skills/compress/scripts/audit-scan.sh
Comment thread plugins/docs-hygiene/skills/compress/scripts/audit-scan.sh
Close the 38 audit-noise routes after re-scan (one Sources relocation),
triage the 136 extract-ssot routes in-tree, and record false-keep sampling
as deferred without opening new issues.

Closes #2735

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/2735-route-sibling-8f91 branch from 43776ae to b5dd54f Compare August 16, 2026 01:13
cursoragent and others added 2 commits August 16, 2026 01:13
Rewrite caveman Step B for cross-tool Bash semantics, honor enabled+marketplace
identity in detect-caveman, ship audit-scan.sh, add yield circuit breaker and
top-10 interview default, and align taxonomy/LATITUDE/docs with the word-level
batch path vs Edit-fallback split.

Closes #2745

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…press audit

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/2745-compress-audit-8f91 branch from 49588fe to afe4153 Compare August 16, 2026 01:14
@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 34s —— View job


Security review (/review:security-review)

  • Gather context (diff, changed files, CLAUDE.md)
  • Invoke /review:security-review skill and follow its procedure
  • Post findings / results

Scope reviewed: full diff origin/cursor/2735-route-sibling-8f91...HEAD at head afe4153 (13 files, +324/-53) — plugins/docs-hygiene/ skill docs (SKILL.md, context/*.md), CHANGELOG.md, plugin.json version bump, evals/evals.json + new fixture, and the two shell scripts (scripts/audit-scan.sh, scripts/detect-caveman.sh) plus their test scripts.

No security issues found.

This is documentation/tooling for the docs-hygiene:compress skill with no security-relevant surface:

  • No GitHub Actions workflow files are touched (no permissions:, triggers, or CI changes).
  • No authentication, authorization, secrets, tokens, or network I/O are involved.
  • scripts/audit-scan.sh (permalink) operates only on local .md paths passed as arguments — quoted throughout, no eval, no unsanitized interpolation into a shell/exec context. grep -E/-o patterns are static literals, not built from file content.
  • scripts/detect-caveman.sh (permalink) pipes claude plugin list --json output into jq via a shell variable (printf '%s' "$json" | jq -r '...') with a fixed filter string, not string-interpolated JSON into the filter — not injectable. The added enabled == true / pinned-id-preference logic is a correctness change, not a trust-boundary one.
  • SKILL.md's revised Step B (temp-dir mechanical-compression backend) still confines writes to a mktemp -d tempdir and only copies back over the real target on explicit success — same safety property as before, restructured only for the "Bash state doesn't persist across tool calls" constraint.
  • Diffed the incremental commit since the prior review pass (01726f9afe4153, the "satisfy markdownlint/typos/shellcheck" fixup): only comment/whitespace additions and an unused-variable removal in audit-scan.sh — no new security-relevant surface.

Per the security-review skill's high-signal bar, no style/lint/correctness findings are reported here (two P2 detection-accuracy items were already raised by the automated Codex review on audit-scan.sh — those are heuristic-correctness, not security, so out of scope for this lane). See /review:code-review for that lane.

@kyle-sexton
kyle-sexton deleted the branch main August 16, 2026 01:21
Base automatically changed from cursor/2735-route-sibling-8f91 to main August 16, 2026 01:21
kyle-sexton added a commit that referenced this pull request Aug 16, 2026
….0) (#2814)

Closes #2745

## Summary

Re-lands docs-hygiene 0.15.0 compress caveman/taxonomy audit
remediations on main after #2812. Replaces #2805/#2811, which were
auto-closed when stack bases were deleted.

## Related

- Completes the docs-hygiene stack after #2792#2794#2795#2812.
- Supersedes closed #2805 and #2811.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit(docs-hygiene): compress skill — inoperable caveman backend, taxonomy/latitude drift, no yield circuit breaker (1H/6M/6L/2I)

2 participants