docs(docs-hygiene): share clean-tree fallback across audit skills (0.14.6) - #2795
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 34s —— View job Security review — no issues found
This PR is documentation-only: it adds Applying the skip gate: condition 2 ("change has no security-relevant surface after reading the diff") applies — there's no injection surface, no auth/access-control logic, no secret/token handling, and no CI/workflow changes to review. No findings to report. |
|
Last security-reviewed head: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4c258199c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude finished @kyle-sexton's task in 2m 4s —— View job Code review complete
This is a docs-only change: a new shared skeleton doc ( I cross-checked the new shared doc's "Who participates" table and the "Deliberate divergences" section against the actual behavior described in each cited
Everything else — link paths ( |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Claude has reviewed this PR 3 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
## Summary - Hoist and export convention-root resolution once per `detect.sh` run so `AUDIT_NOISE_CONTRACT_ROOT` is not lost to command-substitution subshells (auditor F6: configured contract root bare `reviews/`/`handoffs/` no longer falsely exempt). - Restructure the per-line hot path to use nameref helpers (`detect_shapes_into`, `shape_tier_into`, `trim_excerpt`) instead of 2+ `$()` forks per markdown line. - Add `--offset` / `--limit` so repo-wide orchestration can chunk without a per-file shell loop; document in SKILL.md clean-tree defaults. - Bump docs-hygiene to 0.14.4. ## Test plan - [x] `bash plugins/docs-hygiene/skills/audit-noise/scripts/detect.test.sh` — 48/48 pass (includes F6 contract-bare regression + chunk affordance) - [x] Perf smoke: single non-CHANGELOG scan path no longer pays per-line `parse-concern-value.sh` forks; 40×885-line corpus ~7.8s in this environment Closes #2741 ## Related - Base of the docs-hygiene stack (#2794 → #2795 → #2798 → #2805). --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
24841e9 to
8ca3115
Compare
….7) (#2798) ## Summary - Re-scanned all 38 audit-noise-routed paths: 32 clean under current exemptions, 6 CHANGELOG basename-exempt, 1 Tier-2 ghost-ref remediated (`docs/conventions/commit-convention/README.md` design cite → `## Sources`). - Added `plugins/docs-hygiene/context/derivability-route-followups.md` triage board for the 136 extract-ssot routes (synced artifact-protocol cluster already registered; checklists/scaffolds; changelog-parity; pending candidates) — no new issues. - Recorded false-keep sampling backlog as deferred (ephemeral ledger unavailable). - Bump docs-hygiene to 0.14.7. Stacked on #2795 (path mutex — shared version line). ## Test plan - [x] `detect.sh docs/conventions/commit-convention/README.md` → T1=0 T2=0 T3=0 - [x] Full 38-path noise re-scan → only the one remediated finding before the Sources move Closes #2735 ## Related - Stacked on #2795; process-derivability route-to-sibling batch ahead of #2805. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…2794) ## Summary - Skip YAML frontmatter and fenced code blocks during scans. - Opt-out markers must be well-formed HTML comment lines (prose mentions no longer swallow following content). - Section exemption toggles on any ATX heading level (`### Sources` exempts; an H1 after `## Sources` ends it). - Inline `` `code` `` spans are stripped for citation/enum/scope matching; ghost-ref still sees unwrapped path text. - Resolve relative targets before `cd` to repo root; parse spaced filenames from porcelain without `$NF`. - Bump docs-hygiene to 0.14.5. Stacked on #2792 (path mutex — both touch `detect.sh`). ## Test plan - [x] `bash plugins/docs-hygiene/skills/audit-noise/scripts/detect.test.sh` — 59/59 pass Closes #2742 ## Related - Stacked on #2792; continues docs-hygiene audit-noise work toward #2795. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…14.6) Add plugin-level context/clean-tree-fallback.md as the SSOT for the confirmation-gated bare-invocation shape. Cite it from the audit siblings and extract-ssot; teach compress audit on a clean tree to offer the free corpus audit instead of no-opping. Closes #2734 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
0685e65 to
107b7f1
Compare
|
Claude finished @kyle-sexton's task in 1m 0s —— View job Security review — no issues found
Skip gate condition 2 applies: this diff has no security-relevant surface. All 10 changed files are documentation/markdown ( Note: Codex's inline comment on |
….7) (#2812) Closes #2735 ## Summary Re-lands 0.14.7 on main after #2795. Replaces #2810/#2798 which were closed or merged against a deleted stack base. ## Related - Docs-hygiene stack after #2795; precedes 0.15.0 compress remediations. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Claude finished @kyle-sexton's task in 26s —— View job Code review skipped
Per For reference, this PR already received two prior review passes from this lane while open (security review: no issues found; code review: one finding on |
|
Claude finished @cursor[bot]'s task in 40s —— View job Code review — skipped (PR merged)
Per For reference, this PR already received two full reviews from this bot while open (security review: no issues found; code review: one finding on |
….0) (#2814) Closes #2745 ## Summary Re-lands docs-hygiene 0.15.0 compress caveman/taxonomy audit remediations on main after #2812. Replaces #2805/#2811, which were auto-closed when stack bases were deleted. ## Related - Completes the docs-hygiene stack after #2792 → #2794 → #2795 → #2812. - Supersedes closed #2805 and #2811. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
2 participants
Summary
plugins/docs-hygiene/context/clean-tree-fallback.md— shared offer/confirm/no-op skeleton for bare audit invocations.audit-noise,audit-derivability,audit-encapsulation,compress, andextract-ssot; record deliberate divergences (compress mutating; encapsulation "no inherited scope").compress auditon a clean tree now offers the confirmation-gated free corpus audit (report-only) instead of the friendly no-op.Stacked on #2794 (path mutex — shared
plugin.json/ CHANGELOG version line).Test plan
compress/context/target-types.mdrow updated for audit+clean-treeCloses #2734
Related