fix(docs-hygiene): compress caveman/taxonomy audit remediations (0.15.0) - #2805
fix(docs-hygiene): compress caveman/taxonomy audit remediations (0.15.0)#2805kyle-sexton wants to merge 1 commit into
Conversation
Rewrite caveman Step B for cross-tool Bash semantics, honor enabled+marketplace identity in detect-caveman, ship audit-scan.sh, add yield circuit breaker and top-10 interview default, and align taxonomy/LATITUDE/docs with the word-level batch path vs Edit-fallback split. Closes #2745 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 1m 31s —— View job Security review (
|
|
Last security-reviewed head: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ad608af0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| is_signal1_path() { | ||
| local f="$1" base | ||
| base="$(basename "$f")" | ||
| [[ "$f" == *'/.claude/rules/'* || "$f" == */.claude/rules/* ]] && return 0 |
There was a problem hiding this comment.
When the audit receives the repo-relative paths produced by git status or git ls-files, a root rule such as .claude/rules/security.md matches neither pattern because both require a preceding slash. Signal 1 therefore does not force these always-loaded files to SKIP; a sufficiently flavor-heavy root rule can be reported as COMPRESS and included in the repo-wide candidate cohort. Accept .claude/rules/* in addition to absolute and nested forms.
Useful? React with 👍 / 👎.
|
|
||
| tick_pairs=$(grep -o '`' "$file" 2>/dev/null | wc -l | tr -d ' ') | ||
| tick_pairs=$((tick_pairs / 2)) | ||
| path_hits=$(grep -Eoc '(@|[a-z][a-z0-9._/-]+\.(md|cs|sh|json|yaml))' "$file" 2>/dev/null || echo 0) |
There was a problem hiding this comment.
When a paragraph contains several references on the same line, grep -c counts that line once rather than counting each regex match. For example, 11 .md references on one line in a 148-word flavor-heavy file produce a computed density of 6/kw and COMPRESS, although the documented occurrence density is 74/kw and should make the result UNCERTAIN. Use occurrence output such as grep -Eo ... | wc -l so prose line wrapping cannot change classification.
Useful? React with 👍 / 👎.
## Summary - Hoist and export convention-root resolution once per `detect.sh` run so `AUDIT_NOISE_CONTRACT_ROOT` is not lost to command-substitution subshells (auditor F6: configured contract root bare `reviews/`/`handoffs/` no longer falsely exempt). - Restructure the per-line hot path to use nameref helpers (`detect_shapes_into`, `shape_tier_into`, `trim_excerpt`) instead of 2+ `$()` forks per markdown line. - Add `--offset` / `--limit` so repo-wide orchestration can chunk without a per-file shell loop; document in SKILL.md clean-tree defaults. - Bump docs-hygiene to 0.14.4. ## Test plan - [x] `bash plugins/docs-hygiene/skills/audit-noise/scripts/detect.test.sh` — 48/48 pass (includes F6 contract-bare regression + chunk affordance) - [x] Perf smoke: single non-CHANGELOG scan path no longer pays per-line `parse-concern-value.sh` forks; 40×885-line corpus ~7.8s in this environment Closes #2741 ## Related - Base of the docs-hygiene stack (#2794 → #2795 → #2798 → #2805). --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
….7) (#2798) ## Summary - Re-scanned all 38 audit-noise-routed paths: 32 clean under current exemptions, 6 CHANGELOG basename-exempt, 1 Tier-2 ghost-ref remediated (`docs/conventions/commit-convention/README.md` design cite → `## Sources`). - Added `plugins/docs-hygiene/context/derivability-route-followups.md` triage board for the 136 extract-ssot routes (synced artifact-protocol cluster already registered; checklists/scaffolds; changelog-parity; pending candidates) — no new issues. - Recorded false-keep sampling backlog as deferred (ephemeral ledger unavailable). - Bump docs-hygiene to 0.14.7. Stacked on #2795 (path mutex — shared version line). ## Test plan - [x] `detect.sh docs/conventions/commit-convention/README.md` → T1=0 T2=0 T3=0 - [x] Full 38-path noise re-scan → only the one remediated finding before the Sources move Closes #2735 ## Related - Stacked on #2795; process-derivability route-to-sibling batch ahead of #2805. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review. A new push re-triggers this lane only if the caller's |
|
Superseded by #2811 after stack-base deletion. No new issue. |
…14.6) (#2795) ## Summary - Add `plugins/docs-hygiene/context/clean-tree-fallback.md` — shared offer/confirm/no-op skeleton for bare audit invocations. - Cite it from `audit-noise`, `audit-derivability`, `audit-encapsulation`, `compress`, and `extract-ssot`; record deliberate divergences (compress mutating; encapsulation "no inherited scope"). - `compress audit` on a clean tree now offers the confirmation-gated free corpus audit (report-only) instead of the friendly no-op. - Bump docs-hygiene to 0.14.6. Stacked on #2794 (path mutex — shared `plugin.json` / CHANGELOG version line). ## Test plan - [x] Relative cite paths resolve from each skill directory - [x] `compress/context/target-types.md` row updated for audit+clean-tree Closes #2734 ## Related - Stacked on #2794; shares clean-tree fallback for later stack PRs (#2798, #2805). Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
….0) (#2814) Closes #2745 ## Summary Re-lands docs-hygiene 0.15.0 compress caveman/taxonomy audit remediations on main after #2812. Replaces #2805/#2811, which were auto-closed when stack bases were deleted. ## Related - Completes the docs-hygiene stack after #2792 → #2794 → #2795 → #2812. - Supersedes closed #2805 and #2811. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
2 participants
Summary
Remediates the plugin-quality audit findings for
docs-hygiene:compress(#2745):detect-caveman.shrequiresenabled: true, preferscaveman@caveman; fixture tests for disabled/enabledterse-agent.mdfixture; path coupling reduced on evals 9/10scripts/audit-scan.sh+ contract test; audit action calls itdisable-model-invocation: falseBump docs-hygiene to 0.15.0.
Stacked on #2798 (path mutex — shared version line).
Test plan
bash plugins/docs-hygiene/skills/compress/scripts/detect-caveman.test.sh— 14/14bash plugins/docs-hygiene/skills/compress/scripts/audit-scan.test.sh— 3/3audit-scan.shonterse-agent.md→ SKIP (0/kw)Closes #2745
Related