Skip to content

fix(docs-hygiene): compress caveman/taxonomy audit remediations (0.15.0) - #2814

Merged
kyle-sexton merged 2 commits into
mainfrom
cursor/2745-compress-audit-8f91
Aug 16, 2026
Merged

fix(docs-hygiene): compress caveman/taxonomy audit remediations (0.15.0)#2814
kyle-sexton merged 2 commits into
mainfrom
cursor/2745-compress-audit-8f91

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

cursoragent and others added 2 commits August 16, 2026 01:22
Rewrite caveman Step B for cross-tool Bash semantics, honor enabled+marketplace
identity in detect-caveman, ship audit-scan.sh, add yield circuit breaker and
top-10 interview default, and align taxonomy/LATITUDE/docs with the word-level
batch path vs Edit-fallback split.

Closes #2745

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…press audit

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 12s —— View job


Security review — no issues found

Ran /review:security-review (org CI security-review lane) against this PR (origin/main...HEAD, head 43ccce7).

  • Gather context (PR diff, changed files)
  • Run /review:security-review skill per custom instructions
  • Post findings / summary

Skip gate: the change set has no security-relevant surface. All 13 changed files are within plugins/docs-hygiene/ (a docs-compression skill) and consist of:

  • Prose/instruction edits to SKILL.md and context/*.md (compression methodology, temp-file handling docs)
  • evals.json / new eval fixture (evals/fixtures/terse-agent.md)
  • Plugin version bump + CHANGELOG.md
  • Two shell scripts: new scripts/audit-scan.sh (read-only markdown classifier) and modified scripts/detect-caveman.sh, plus their .test.sh companions

I checked the shell scripts specifically for the usual trust-boundary issues (command injection via filenames, unsafe eval, unquoted expansion, unsafe temp-file/trap handling):

  • audit-scan.sh rejects any arg starting with - before use, quotes all path variables ("$f", "$file") through grep/wc/basename, and only reads/classifies files — no writes, no network, no credential handling.
  • detect-caveman.sh's change actually tightens trust: it now requires enabled == true (preferring the pinned caveman@caveman id) instead of accepting any caveman@* install, so a disabled/rogue plugin can no longer report as available. claude plugin list --json output is piped through jq (no eval), so untrusted JSON content can't be interpreted as shell.
  • SKILL.md's Step B rewrite removes a stale trap ... EXIT (which doesn't persist across separate tool calls) in favor of explicit rm -rf cleanup on both success and failure paths of the tempdir copy — a correctness fix, not a new risk; the target file is still only overwritten on backend success.

No injection, auth/access-control, secret-handling, or GitHub Actions permission/trigger issues in this diff. Per the skip-gate rule, no further findings to report.

@github-actions

Copy link
Copy Markdown

Last security-reviewed head: 43ccce72c23df3d46741f6ab6bfa962c349b0b48. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43ccce72c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/docs-hygiene/skills/compress/scripts/audit-scan.sh
Comment thread plugins/docs-hygiene/skills/compress/scripts/audit-scan.sh
@kyle-sexton
kyle-sexton merged commit bdb0dd4 into main Aug 16, 2026
44 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/2745-compress-audit-8f91 branch August 16, 2026 01:30
@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 22s —— View job


Code review — skip gate triggered

  • Gather context
  • Check skip gate conditions
  • Post result

Result: skipped. This PR is MERGED (closed), and the /review:code-review skip gate stops before deep review whenever "PR is closed or not open." No inline comments were posted.

If a fresh review is needed, please open it as a new PR or re-open this one and re-trigger @claude.

@github-actions

Copy link
Copy Markdown

Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit(docs-hygiene): compress skill — inoperable caveman backend, taxonomy/latitude drift, no yield circuit breaker (1H/6M/6L/2I)

2 participants