Skip to content

test(layout): move the Abliteration quota test to a shard to restore the layout.json size cap on dev - #7607

Merged
lidge-jun merged 1 commit into
devfrom
fix/layout-ratchet-abliteration
Oct 23, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/layout-ratchet-abliteration

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

dev is red: #7581 added provider-quota-abliteration.test.ts as its own line in scripts/test-layout/layout.json, which took the file from 1999 to 2000 lines. The file-size ratchet caps it below 2000, so tests/ci-workflows/file-size-ratchet.test.ts (저장소 스캔: 커밋된 기준선 대비 offender가 없다) now fails on dev with scripts/test-layout/layout.json NEW_OVERSIZED, and every branch merged with dev inherits the failure.

This moves that one entry to the existing layout-adapters.json shard (domain unchanged: providers), so layout.json is back to 1999 lines. No test moves directories and no domain changes.

Verification

On dev e8549d4 + this commit, isolated HOME:

  • bun test tests/test-layout.test.ts: 2 pass
  • bun test tests/ci-workflows/file-size-ratchet.test.ts: 9 pass (fails on plain dev: 8 pass / 1 fail)
  • bun test tests/providers/provider-quota-abliteration.test.ts: 11 pass
  • bun run structure:check: exit 0

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Tests
    • Updated the automated test layout so provider quota coverage is grouped with provider tests. The existing Google Vertex test placement is unchanged. This is an organizational update to test coverage; it does not change application functionality or alter any user-facing behavior.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 23, 2026 07:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T07:33:00.754589Z d9e50e2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 7416f18 and d9e50e2.

📒 Files selected for processing: 2
  • scripts/test-layout/layout-adapters.json
  • scripts/test-layout/layout.json
💤 Files with no reviewable changes: 1
  • scripts/test-layout/layout.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The quota-abliteration test mapping was removed from scripts/test-layout/layout.json and added to scripts/test-layout/layout-adapters.json under providers. The existing Google Vertex mapping remains unchanged.

Changes: Test layout mapping

Layer / File(s) Summary
Move quota test layout mapping
scripts/test-layout/layout.json, scripts/test-layout/layout-adapters.json
The quota-abliteration test mapping was removed from the main layout and added to the adapter layout’s providers mapping. The Google Vertex mapping remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

  • lidge-jun/opencodex#7593: This PR also changes scripts/test-layout/layout.json. Its added entries may affect the file-size ratchet, so sequencing or reconciling the line count may be relevant.

Suggested labels: chore

Suggested reviewers: chilung-cgu, btorres0318

Merge Risk: ⚪ Minimal · up to d9e50

The layout change is narrowly scoped and ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: moving the Abliteration quota test to a shard to restore the layout.json size cap on dev.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Oct 23, 2026
@lidge-jun
lidge-jun merged commit 03bcf78 into dev Oct 23, 2026
33 checks passed
@lidge-jun
lidge-jun deleted the fix/layout-ratchet-abliteration branch October 23, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant