Skip to content

docs(integrations): restore translated LazyCodex role effort guide sections - #6970

Merged
lidge-jun merged 1 commit into
devfrom
codex/6960-role-effort-locale-docs-261012
Oct 12, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/6960-role-effort-locale-docs-261012

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

#6960 carried LilMGenius's LazyCodex role reasoning-effort series (#6907, #6908, #6909) but updated only the English guides/integrations.md. The seven translated guide sections from #6907 were dropped, so the fr, ja, ko, ru, tr, zh-cn and zh-tw guides said nothing about picking or clearing a role's effort.

This restores those sections, inserted before ## Kilo to match the English page order, and rewrites them to the behavior that actually landed on dev:

  • The row option is named with each locale's GUI string for Inherit effort (integrations.lazycodexRoles.effortDefault); feat(gui): pick each LazyCodex role's reasoning effort next to its model #6907 used a shorter "Inherit" label that no longer exists.
  • Changing an existing pin to Inherit effort sends "effort": null, which removes the root model_reasoning_effort line and its trailing comment plus [codex].agents.<role>.reasoning; a multiline or non-string value is refused with 409 unsupported_model_value; Codex then resolves effort as for any role without an override.
  • Auto-assign proposes an effort for every sized role whose model has a non-empty ladder, and Apply / Apply all / --apply inserts or replaces it. An empty ladder gives proposedEffort: null, Apply omits effort, and a null proposal never clears a pin. (feat(gui): pick each LazyCodex role's reasoning effort next to its model #6907 described only the no-proposal case.)
  • When the role file saves but the omo.jsonc write fails, Retry omo.jsonc resends the same choice, including a null clear, and a later effort-less Save or Auto-assign Apply carries it; an explicit effort takes its place.

The English guide gains one paragraph describing that retry, so no translation documents behavior the canonical English page leaves out. No code, GUI or test changes.

Co-authored-by: LilMGenius smsmeee@naver.com

Verification

  • cd docs-site && bun install --frozen-lockfile && ASTRO_TELEMETRY_DISABLED=1 bun run build: exit 0, 569 pages, 79353 internal links checked. All seven locale pages render the new section.
  • bun test tests/ci-workflows/docs-*.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/ci-workflows/repo-hygiene.test.ts tests/ci-workflows/structure-ssot.test.ts tests/ci-workflows/skill-ocx-workflows.test.ts tests/codex-integration/codex-inject-history-wording.test.ts: 419 pass, 0 fail (17 files).
  • bun run structure:check, bun run privacy:scan, git diff --check origin/dev: exit 0.
  • Docs-only change: bun run typecheck and the full bun run test were not run locally because no TypeScript, GUI or test file changed; required CI covers them.
  • Every claim was checked against gui/src/pages/integrations/LazyCodexRoleModels.tsx, LazyCodexRoleAutoAssign.tsx, src/codex/agent-role-models.ts and src/codex/role-auto-assign.ts, and every bolded label against gui/src/i18n/{fr,ja,ko,ru,tr,zh,zh-TW}.ts. An independent cross-model review found no behavioral contradictions with the English page; its four wording findings (ru, ja, tr, fr) are folded in.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Documentation
    • Added multilingual guidance for configuring model reasoning effort per omo (Codex / LazyCodex) role through the interface or CLI.
    • Explained effort inheritance, automatic-assignment suggestions, and how mirror-write failures can be retried.

…ctions

#6960 carried #6907 but updated only the English guide. Restore the
fr, ja, ko, ru, tr, zh-cn and zh-tw sections, corrected to the behavior
that landed: the "Inherit effort" row label, null clears, auto-assign
effort for every sized role, empty ladders never clearing a pin, and the
omo.jsonc mirror retry. The English guide now describes Retry omo.jsonc.

Co-authored-by: LilMGenius <smsmeee@naver.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 12, 2026 06:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T06:59:37.157049Z 5caee35 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 528f222d-7016-4603-8839-2e53ce511e23

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb1fc3 and 5caee35.


📒 Files selected for processing (8)
  • docs-site/src/content/docs/fr/guides/integrations.md
  • docs-site/src/content/docs/guides/integrations.md
  • docs-site/src/content/docs/ja/guides/integrations.md
  • docs-site/src/content/docs/ko/guides/integrations.md
  • docs-site/src/content/docs/ru/guides/integrations.md
  • docs-site/src/content/docs/tr/guides/integrations.md
  • docs-site/src/content/docs/zh-cn/guides/integrations.md
  • docs-site/src/content/docs/zh-tw/guides/integrations.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.



📝 Walkthrough

Walkthrough

The integration guides now document per-role reasoning effort settings for omo Codex and LazyCodex. They cover role-file updates, inheritance, optional omo.jsonc mirroring and retries, and automatic-assignment effort proposals.

Changes

Per-role reasoning effort

Layer / File(s) Summary
Role effort settings and mirror behavior
docs-site/src/content/docs/guides/integrations.md, docs-site/src/content/docs/{fr,ja,ko,ru,tr,zh-cn,zh-tw}/guides/integrations.md
The guides describe saving model and effort settings, clearing supported overrides through inheritance, and handling unsupported values. They also document optional omo.jsonc mirrors, retrying failed mirror writes, and automatic-assignment proposals.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 5caee

This restores translated documentation sections that match the implemented behavior. There is no code, runtime or data impact, so merging carries minimal risk.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the documentation scope and main change: restoring translated LazyCodex role-effort sections in the integration guides. It is concise and specific.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 12, 2026
@lidge-jun
lidge-jun merged commit 561c55b into dev Oct 12, 2026
29 of 30 checks passed
@lidge-jun
lidge-jun deleted the codex/6960-role-effort-locale-docs-261012 branch October 12, 2026 07:24
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (MAINTAINERS.md dev-only path; actor @lidge-jun, admin), merged as 561c55b; head 5caee35d2a bound with --match-head-commit, no unresolved threads. Exact-head checks all passed (docs site build, privacy gate, enforce-target, hygiene). Author verification: docs-site build 0 (569 pages), docs ci-workflows tests 419/0, structure:check and privacy:scan 0; GPT-6.1-Sol translation review NEAR-PASS with wording findings folded. A union check with #6975 (same English guide) merges cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant