Repository navigation
docs(integrations): describe effort-only role saves in the translated guides - #6976
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable documentation mismatch remains established for this change, so it presents no identified merge-blocking risk. Pre-merge checks |
|
|
✅ Deterministic PR hygiene checks passed. |
Mirror #6975's English role-models text in the fr, ja, ko, ru, tr, zh-cn and zh-tw guides: a row without a model pin can save an effort alone, omitting model keeps the role-file pin and the omo.jsonc model, a missing omo.jsonc entry gets reasoning only when a supported level is stored, a null model is refused with 400 invalid_model, an empty update with 400 empty_update, and ocx agent roles set always takes a model. Co-authored-by: LilMGenius <smsmeee@naver.com>
#6975's English said a role without an omo.jsonc entry always gets one holding only reasoning. writeOmoRoleModel only creates it when a level LazyCodex supports is saved (none is written as off); for such a role a clear or ultra adds no entry. The translations already say this. Co-authored-by: LilMGenius <smsmeee@naver.com>
1fd9f11 to
a3ffac1
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Ingwannu
left a comment
There was a problem hiding this comment.
Reviewed documentation head a3ffac15d2d58ec2f5fee56aba9cc57c9adb6661 against trusted dev a0191a1b6fd921a6e5a9d12cb123c8df88b023e7.
The effort-only descriptions agree with the current route and omo writer: omitted model preserves inheritance/pins, null model is rejected, an empty update is refused before role/omo file reads, and a missing omo role entry is created only for a supported reasoning value. The English correction correctly excludes clear/ultra from absent-entry creation; none maps to off. I found no concrete contract blocker in the changed guide text. This is factual documentation review, not an autonomous UI/translation redesign.
Exact-head Cross-platform CI run 38219447006 completed successfully. I did not rerun a docs build or runtime suite for unchanged implementation. The latest target/readiness run 38219722923 remains pending at this check; prior cancelled gate runs are not passes. This comment does not waive that gate or independently certify every locale's idiomatic phrasing.
|
Maintainer integration into |
Summary
#6975 (now on
dev) lets a row whose role has no model pin save an effort on its own. This carries that behavior into the fr, ja, ko, ru, tr, zh-cn and zh-tw guides that #6970 added, and narrows one English sentence #6975 added.PUT /api/codex-agent-roles/{role}. Omittingmodelkeeps the role-file pin and the omo.jsoncmodel, and the dashboard sends that effort-only request for such rows. Anullmodel is refused with 400invalid_model. A body with neithermodelnoreffortis refused with 400empty_updatebefore any file is read.ocx agent roles setalways takes a model.reasoning".writeOmoRoleModel(src/clients/omo-role-models.ts) creates that entry only when the saved effort is one LazyCodex supports (omoReasoningForwritesnoneasoff). For a role without an entry, a clear orultrapassesnulland the writer returnsunchanged. The sentence now says this and is scoped to the absent-entry case; an existing entry still loses its olderreasoningon a clear orultra, as the paragraph above it says. The translations already used this narrower wording.#6975 also changed the GUI
omoCommentsstring to[codex].agents.{role}. That needs no guide edit, because the guides only say to set the value by hand.Co-authored-by: LilMGenius smsmeee@naver.com
Verification
cd docs-site && bun install --frozen-lockfile && ASTRO_TELEMETRY_DISABLED=1 bun run build: exit 0, 569 pages, 79353 internal links checked.bun test tests/ci-workflows/docs-*.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/ci-workflows/repo-hygiene.test.ts tests/ci-workflows/structure-ssot.test.ts tests/ci-workflows/skill-ocx-workflows.test.ts tests/codex-integration/codex-inject-history-wording.test.ts: 419 pass, 0 fail.bun run structure:check,bun run privacy:scan,git diff --check origin/dev: exit 0.Checklist
Summary by CodeRabbit