Repository navigation
fix: recover blocked shared ssh connections - #5252
Conversation
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 45.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 40 functions across 9 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly summarizes the main change: recovery of blocked shared SSH connections. Description check The description explains the SSH recovery behavior, retry limits, session preservation, and reported validation. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
✅ Action performedReview finished.
|
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
JJLiebig
added
the
ai-review
Keep our fork features (federation, gram, api-bridge, guest, push, notifications, agent archive/forget/transfer, accounts, staged updates) alongside upstream's v0.9.4, v0.9.5 and unreleased fixes. Most source conflicts keep our fork's Method enum (upstream's define_operations! macro cannot express our cfg-gated and serde-skipped variants). Detection manifests keep our extra rules; Codex integration scripts switch to upstream's canonical version. Upstream highlights: - Persistent macOS/Linux server (SIGHUP no longer stops it) - Session saves on system shutdown/restart - Plugin update command - Keyboard/IME fixes (non-Latin layouts, Ctrl+Shift, accents) - Windows improvements (PowerShell 7 default, clipboard, notifications) - SSH compression and bandwidth improvements - Performance fixes (CPU, memory, hidden pane improvements) - Codex, Claude Code, Pi, Antigravity, Grok detection updates - New platform modules (launchd spawn, power/shutdown) - Vendor patches (libghostty-vt cursor hyperlink, portable-pty Windows dir) refs herdrdev#5310, herdrdev#5278, herdrdev#5236, herdrdev#5303, herdrdev#5308, herdrdev#5275, herdrdev#5280, herdrdev#5282, herdrdev#5277, herdrdev#5276, herdrdev#5270, herdrdev#5269, herdrdev#5252, herdrdev#5249, herdrdev#5247, herdrdev#5241, herdrdev#5242, herdrdev#5192, herdrdev#5232, herdrdev#5212, herdrdev#5174, herdrdev#5173, herdrdev#5171, herdrdev#5092
* fix: recover blocked shared ssh connections refs herdrdev#4721 * test: support shared ssh checks in client fixtures refs herdrdev#4721 * test: separate ssh cancellation from timeout scheduling refs herdrdev#4721
Recover blocked shared SSH reuse when a fresh connection to the same host works, while preserving existing sessions. Saved TUI attach checks reuse up front; healthy API/status calls stay unchanged and recover only after a read-only failure. Connection setup retries once, and remote mutations are never replayed.
Validated with
just check, focused Unix tests/lint, and real WSL OpenSSH loopback tests for frozen TCP, two active channels, concurrent replacement, ProxyJump, slow healthy shells, and host-key/authentication failures. Physical macOS sleep and WAN/load were not tested.