[JJLiebig]

Cancelled reconnects could hang while another process kept their pipes open. Cleanup now finishes and stops its own SSH process before retrying the same machine. Final output and useful SSH errors are preserved.

Merge order: after #5242 (already merged).

Tests cover stalled reads/writes, cancellation, and replacement connections; just check passed.

[kangal-bot]

@coderabbitai review
@greptileai

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: d5847fda-4bf1-4c81-9374-ceed10604530

📥 Commits

Reviewing files that changed from the base of the PR and between d0297a0 and ec1b0b7.

📒 Files selected for processing: 4

• src/client/endpoint/supervisor.rs
• src/remote/attach.rs
• src/remote/process.rs
• src/remote/saved.rs

💤 Files with no reviewable changes: 2

• src/client/endpoint/supervisor.rs
• src/remote/process.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The change adds cancellation and completion state to endpoint connection attempts. Local connections, handshakes, SSH subprocesses, and bridge I/O now support cancellation. Replaced endpoints wait for unfinished attempts, and transports retain completion state until they are dropped. Tests cover cancellation, timeouts, endpoint replacement, stream closure, and subprocess output handling.

Suggested reviewers: ogulcancelik

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to ec1b0

This change makes endpoint and SSH connection attempts cancellable and cleans up their connections before a retry. The review found no remaining issue. The suspected Windows hang during cancellation does not occur with the dependency version in use.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 23.08% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 91 functions across 12 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: cancelling and cleaning up endpoint connection attempts.
Description check		The description directly explains the cancellation, cleanup, SSH process handling, preserved output, tests, and merge-order requirement.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

This PR makes endpoint connection attempts cancellable and waits for their cleanup before retrying the same endpoint.

• Replaced endpoint connections wait for the old attempt to close.
• SSH commands stop their own pipe work and keep useful output.
• SSH bridges stop stalled forwarding and deliver final output.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start connection attempt] --> B[Connect and complete handshake]
    B --> C[Writer owns bridge and completion flag]
    C --> D[Endpoint retires or disconnects]
    D --> E[Stop writer and cancel SSH work]
    E --> F[Close stream and drop bridge]
    F --> G[Mark attempt complete]
    G --> H[Allow replacement attempt]

Loading

_{Reviews (2) · Last reviewed commit: "fix: preserve nonblocking bridge output ..." · Reviewed by Greptile}

[JJLiebig]

@coderabbitai review
@greptileai

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.