Repository navigation
refactor(settings): remove page overlap, files at once, highlight code and chat page keys - #1104
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 14, 2026
Contrast, Text smoothing, Panel motion, the UI and code fonts and Folder and branch never shipped (#951, #1033 are after v0.4.8), so their changelog fragments no longer add them and trim-settings removes only the five that shipped. Drops the pace text from the guide, removed settings from DESIGN.md's page list, a vacuous test, the contrast.ts credit and FontFamilyInput's unused placeholder prop.
…actor/trim-settings-2 # Conflicts: # src/lib/settings.test.ts
…settings from the docs DESIGN.md's Settings page list and paging notes and the guide's shortcut rows still described Highlight code, the chat paging toggle, Files at once and a configurable page overlap.
devswha
added a commit
that referenced
this pull request
Oct 14, 2026
devswha
added a commit
that referenced
this pull request
Oct 14, 2026
#1105) Stacked on #1104 (itself on #1099); retarget to `main` once they merge. ## Change The settings snapshot now covers every setting the app keeps after #1099 and #1104, so a later trim can be decided from data: - **Added:** `paletteLight`, `paletteDark`, `uiFontSize` (11–20, or `null` for the screen's size), `diffStyle`, and `usageOrderCustom`, a yes/no for whether the usage meters' accounts were put in an order of the user's own (the accounts themselves are never sent, as for `usageHiddenCount`). - **Dropped:** the nine fields #1099 and #1104 kept sending as fixed values (`terminalCursorStyle`, `terminalCursorBlink`, `narrowPaneFont`, `showSuggestionChip`, `usagePace`, `highlightCode`, `pageOverlapRows`, `chatPageKeys`, `attachLimit`). No released version sends a snapshot yet (0.4.8 still sends `changed_settings`), so nothing in the field breaks. - `palette` accepts only the three palettes the app still has. - `TelemetrySourceSettings` no longer exempts the four settings it listed as "not collected", so a new setting still needs an explicit decision. ## Deployed - Production D1: `ALTER TABLE events ADD COLUMN settings TEXT` (telemetry/README.md). The table now has `settings`; all 1967 existing rows were kept, with `settings` NULL. - Worker deployed from this branch (version `84a7f138`), and `telemetry/deployed.json` updated with `bun scripts/release-guards.ts --worker-deployed`. A malformed snapshot posted to the live endpoint is refused with 400. ## Validation - `bun run check fast`: generated types, typecheck and build pass. Its unit run caught the hard-coded key count in `api.test.ts` (53 → 49); after that fix, `bun run test:unit` passes 3584, 0 fail. - `telemetry/worker.test.ts` (full snapshot, legacy `changed_settings`, real-table INSERT and the README queries), `server/telemetry.test.ts`, `settings.test.ts` and `release-guards.test.ts` pass.
This was referenced Oct 14, 2026
devswha
added a commit
that referenced
this pull request
Oct 14, 2026
…age-key settings (#1110) Docs-only follow-up to #1099, #1101 and #1104, from a post-merge review of main 709fc70. - DESIGN.md: drop the Contrast setting's stepper reset arrow and its WCAG constraint bullet (the setting and its section went with #1099). - DESIGN.md and the `SETTING_SCOPE` comment in `src/lib/settings.ts`: code highlighting is no longer a shared setting (#1104 removed it). - DESIGN.md: the plain chat page keys are always on, not opt-in (#1104). - DESIGN.md: the pane header's ellipsis follows `any-pointer: coarse`, matching #1101's touch-laptop fix. No behavior change; no changelog fragment. Verified with `bun run typecheck` and `HERDR_TEST_MODE=unit bun test ./src/conventions.test.ts ./scripts/conventions.test.ts` (0 fail).
This was referenced Oct 14, 2026
devswha
added a commit
that referenced
this pull request
Oct 15, 2026
aNNdii
added a commit
to aNNdii/herdr-web-ui
that referenced
this pull request
Oct 16, 2026
…#1237) into next Conflicts resolved in 24 files: - Find in messages is gone upstream (devswha#1140): the comment-mode toggle takes its place at the chat's top right, and the transcript leaves room for it only while it shows. - highlightCode is removed with upstream's settings cleanup (devswha#1104). - The docked file panel (devswha#1224) gets the file comments: the dialog and the panel share the commentable body, the toggle and the viewer's props. - submitNote/submitRefusal take upstream's `agent` first and the fork's `agentOnly` after it; SubmitOptions gains upstream's resendId/generation, so a held copy with comments resends agent-only under its resend id; the server's resend paths keep `typed: false`. - Telemetry reports every setting except the fork's comment settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1099; retarget to
mainonce it merges.Change
Removes four more settings, each fixed at one value:
PAGE_OVERLAP_ROWSinlib/pageScroll.ts); the Paging group is gone with itPROVIDER_SEND_TURN_MAX_ATTACHMENTS = 100); the note still says how many were left outThese came from #811 (@kratam), #863 (@demrom) and #671 (@aNNdii). Wheel scroll speed (#274) stays: xterm sends one report per wheel event, so neither the OS nor herdr's
mouse_scroll_linescan stand in for it.diffColorableloses its setting argument;HighlightedCode,FileViewerandTerminalViewportToolsno longer read settings.highlightCodeleaves the shared preferences.shared/telemetry.tsis unchanged, as in refactor(settings): remove eleven maintainer-added settings #1099: the snapshot sends the fixed values.attachLimitis sent as 50, the schema's top, since 100 would fail its check.ui-regressionpicks 101 files (the first too large) and expects "the first 100 of 101";pane-paging-demo-regressiondrops the switch and the overlap steps, and keeps its one-pixel fractional pages with a line taller than the view;terminal-viewport-regressionpages once at the fixed overlap;application-paging-regression,file-viewer-regressionandvirtual-source-browser-qadrop the removed cases.Validation
bun run check fast: generated types, typecheck, build, unit tests (3584 pass, 0 fail).bun run check run bun scripts/<name>.ts, each passing:ui-regression,terminal-viewport-regression,application-paging-regression,file-viewer-regression,virtual-source-browser-qa.pane-paging-demo-regression,settings-pages-demo-regression(every Settings page fits 320px in en/ko/ja/zh).