[devswha]

Stacked on #1104 (itself on #1099); retarget to main once they merge.

Change

The settings snapshot now covers every setting the app keeps after #1099 and #1104, so a later trim can be decided from data:

• Added: paletteLight, paletteDark, uiFontSize (11–20, or null for the screen's size), diffStyle, and usageOrderCustom, a yes/no for whether the usage meters' accounts were put in an order of the user's own (the accounts themselves are never sent, as for usageHiddenCount).
• Dropped: the nine fields refactor(settings): remove eleven maintainer-added settings #1099 and refactor(settings): remove page overlap, files at once, highlight code and chat page keys #1104 kept sending as fixed values (terminalCursorStyle, terminalCursorBlink, narrowPaneFont, showSuggestionChip, usagePace, highlightCode, pageOverlapRows, chatPageKeys, attachLimit). No released version sends a snapshot yet (0.4.8 still sends changed_settings), so nothing in the field breaks.
• palette accepts only the three palettes the app still has.
• TelemetrySourceSettings no longer exempts the four settings it listed as "not collected", so a new setting still needs an explicit decision.

Deployed

• Production D1: ALTER TABLE events ADD COLUMN settings TEXT (telemetry/README.md). The table now has settings; all 1967 existing rows were kept, with settings NULL.
• Worker deployed from this branch (version 84a7f138), and telemetry/deployed.json updated with bun scripts/release-guards.ts --worker-deployed. A malformed snapshot posted to the live endpoint is refused with 400.

Validation

• bun run check fast: generated types, typecheck and build pass. Its unit run caught the hard-coded key count in api.test.ts (53 → 49); after that fix, bun run test:unit passes 3584, 0 fail.
• telemetry/worker.test.ts (full snapshot, legacy changed_settings, real-table INSERT and the README queries), server/telemetry.test.ts, settings.test.ts and release-guards.test.ts pass.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2520447e-2ed9-4e47-9662-cd2909dec8ac

📥 Commits

Reviewing files that changed from the base of the PR and between 97f06f3 and c3c0439.

📒 Files selected for processing: 8

• changelog.d/telemetry-all-settings.md
• docs/guide.md
• shared/telemetry.ts
• src/lib/api.test.ts
• src/lib/settings.test.ts
• src/lib/settings.ts
• telemetry/deployed.json
• telemetry/worker.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

• Telemetry
  • Anonymous usage counts now include selected light and dark palettes, interface font size, and diff layout.
  • They also indicate whether usage-meter accounts have ever been reordered, without reporting account names or their order.
  • Settings removed from this release are no longer included in telemetry. Customization indicators cover fonts, shortcuts, key-bar layouts, quick replies, and usage-meter account order.

The telemetry snapshot and validator now use a revised settings allowlist. The snapshot includes light and dark palettes, UI font size, diff style, and usage-order customization. Documentation and tests reflect the updated fields.

Changes: Anonymous telemetry settings

Layer / File(s)	Summary
Snapshot contract and output shared/telemetry.ts, src/lib/settings.ts, docs/guide.md, changelog.d/telemetry-all-settings.md	The contract and validator add palette variants, nullable UI font size, diff style, and usage-order customization. The snapshot reports these settings and removes legacy fields. The documentation and changelog describe the updated reported settings.
Snapshot validation src/lib/settings.test.ts, src/lib/api.test.ts, telemetry/worker.test.ts, telemetry/deployed.json	Snapshot expectations and the worker fixture reflect the revised settings. The expected snapshot key count and recorded deployed hash are updated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: haeminway1

Merge Risk: ⚪ Minimal · up to c3c04

The snapshot adds sanitized theme, font, and diff preferences while reporting account-order customization as a boolean, not account details. No actionable merge risk remains.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main telemetry change: reporting remaining settings and removing obsolete fields.
Description check		The description includes the required Change and Validation sections. It explains the behavior changes, deployment details, and validation results with relevant test coverage.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. (3 skipped: 3 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}