[devswha]

Summary

Four review fixes from cc86059 and 66599c7 never reached main when #967 merged. I checked each claim against origin/main (a338f8b) and found no equivalent handling for any of them. All four are restored here on main's current probe design (pauseProbe/probePaused). The original endProbe(answered)/probeAnswered scheme is not brought back: main handles the hidden-page case differently on purpose, by keeping submits waiting (ws.test.ts "keeps a submit and a secret waiting when the page hides during a probe").

Dropped fix	Gap on main	Restored as
Composer send refused beside a held terminal draft (cc86059)	submitComposerMessage never checked draftHeldForRef. The message box, quick sends and a queued "Send now" typed text and pressed Enter after a partial line that had already reached the shell.	submitComposerMessage answers held_input. submitNote gives the held-input note.
held_input counts as nothing typed (66599c7)	submitNotTyped did not list it, so a refused queued row would be marked uncertain.	Added to submitNotTyped. A refused "Send now" now stays held.
Probe pong goes on to handlers, and the poll re-reads canInput() (cc86059)	ws.ts returned early on every pong. If a frame arrived during the probe, the view stored inputReady=false. On a quiet pane, the "Waiting for terminal input…" banner and the disabled key bar then stayed until some later frame arrived.	The pong reaches the handlers after endProbe(). PaneTerminal's 1 s poll calls setInputReady(socket.canInput(pane)).
A snapshot without ping ends a probe (cc86059)	A probe sent before the snapshot, on ping support remembered from the last connection, dropped a healthy older bridge after 3 s + 3 s. If the page hid before the snapshot, the paused probe was never cleared, because probe() returns early on !pingKnown. canInput() then stayed false for the whole connection.	The snapshot handler calls endProbe() when !pingKnown && this.probing. This covers both the running and the paused case.

Tests

• ws.test.ts: three tests from cc86059, adapted to main. They cover the pong reaching the handlers, the snapshot without ping ending a running probe while the connection and a waiting submit carry on, and the paused-probe variant. I ran all three against main's unfixed ws.ts and they failed.
• compose.test.ts: checks the held_input entries for submitNotTyped and submitNote.
• bun run check fast: typecheck, build and lint pass. server/portal.test.ts failed once in the parallel unit run. It passes on its own, and this PR does not touch that file.
• Browser runs with CI=1 bun run check run: ui-regression.ts (held draft, composer and terminal input checks), ui-contexts-regression.ts, terminal-input-regression.ts, held-rows-demo-regression.ts and pending-pane-switch-regression.ts all pass.

Docs: I updated src/AGENTS.md (WS client and Held terminal draft rows) and extended changelog.d/ws-liveness-probe.md.

🤖 Generated with Claude Code

Review

Fixes from the review, in a8752f8:

• Medium: Send now on a server-owned queued row skipped the held-input guard. actOnPending sent pending-action straight away, and the server pastes the text and presses Enter for non-Claude agents, so a partial line left in the pty would run with the message. The guard now runs in actOnPending for every Send now, before begin. It refuses with held_input, does not mark the row uncertain, and leaves Send now (once the draft is settled) and Discard working. The changelog fragment and the src/AGENTS.md row are now accurate as written.
• Low: no test covered the composer guard or the poll's canInput re-read. scripts/pending-pane-switch-regression.ts now holds a terminal draft and checks three things: Send now on a server-owned row sends no pending-action and shows the held note, a message-box send sends no submit and keeps its text, and Send now delivers exactly once after Discard. scripts/terminal-input-regression.ts holds the probe's pings on a quiet pane. It checks that "Waiting for terminal input…" shows within about a second and clears after the pong. I confirmed each test fails without its fix.
• Low: a refused Send now on a row showed the raw English reason. PendingMessages now sends held_input through submitNote along with input_draft. A new unit test, src/components/PendingMessages.test.tsx, renders it in Korean.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2d9cee9a-13e4-4185-a0f4-b29cabf1714e

📥 Commits

Reviewing files that changed from the base of the PR and between a338f8b and a8752f8.

📒 Files selected for processing (11)

• changelog.d/ws-liveness-probe.md
• scripts/pending-pane-switch-regression.ts
• scripts/terminal-input-regression.ts
• src/AGENTS.md
• src/components/PaneTerminal.tsx
• src/components/PendingMessages.test.tsx
• src/components/PendingMessages.tsx
• src/lib/compose.test.ts
• src/lib/compose.ts
• src/lib/ws.test.ts
• src/lib/ws.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}