revert: remove cfn-lint integration - #4494
Merged
Merged
Conversation
sriram-mv
approved these changes
Dec 16, 2022
mndeveci
enabled auto-merge (squash)
December 16, 2022 23:17
jfuss
approved these changes
Dec 16, 2022
8 tasks
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Dec 19, 2022
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)" This reverts commit bea3bc0. * Revert "fix: Update expected message read validate lint integration test (aws#4488)" This reverts commit abd7c03. * Revert "Update lint helpand output message (aws#4489)" This reverts commit 3304955. * Revert "fix: `pyinstaller` binaries (aws#4486)" This reverts commit b8a939d. * Revert "fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)" This reverts commit ce7143c. * Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)" This reverts commit 2fd533f.
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Dec 19, 2022
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)" This reverts commit bea3bc0. * Revert "fix: Update expected message read validate lint integration test (aws#4488)" This reverts commit abd7c03. * Revert "Update lint helpand output message (aws#4489)" This reverts commit 3304955. * Revert "fix: `pyinstaller` binaries (aws#4486)" This reverts commit b8a939d. * Revert "fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)" This reverts commit ce7143c. * Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)" This reverts commit 2fd533f.
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Dec 19, 2022
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)" This reverts commit bea3bc0. * Revert "fix: Update expected message read validate lint integration test (aws#4488)" This reverts commit abd7c03. * Revert "Update lint helpand output message (aws#4489)" This reverts commit 3304955. * Revert "fix: `pyinstaller` binaries (aws#4486)" This reverts commit b8a939d. * Revert "fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)" This reverts commit ce7143c. * Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)" This reverts commit 2fd533f.
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Dec 19, 2022
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)" This reverts commit bea3bc0. * Revert "fix: Update expected message read validate lint integration test (aws#4488)" This reverts commit abd7c03. * Revert "Update lint helpand output message (aws#4489)" This reverts commit 3304955. * Revert "fix: `pyinstaller` binaries (aws#4486)" This reverts commit b8a939d. * Revert "fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)" This reverts commit ce7143c. * Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)" This reverts commit 2fd533f.
sriram-mv
added a commit
to sriram-mv/aws-sam-cli
that referenced
this pull request
Jan 10, 2023
This reverts commit 42e512d.
8 tasks
sriram-mv
added a commit
that referenced
this pull request
Jan 10, 2023
* Revert "revert: remove cfn-lint integration (#4494)" This reverts commit 42e512d. * fix: add bzip2 devel for pyinstaller build - linux * fix: run `make update reproducible-reqs` * fix: `make black` * Update third party license to include bzip2 Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.