Skip to content

fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement - #4479

Merged
mndeveci merged 2 commits into
aws:developfrom
qingchm:cfnlint-integ
Dec 14, 2022
Merged

fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement#4479
mndeveci merged 2 commits into
aws:developfrom
qingchm:cfnlint-integ

Conversation

@qingchm

@qingchm qingchm commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

  • The validate integration tests are failing due to the expected non-lint output pattern not matching with what sam validate without --lint option will log to stdout
  • Validate command will fail for using the --lint option if the pyyaml version is not >=5.4.1

Why is this change necessary?

  • To fix the failing integration tests and resolve the console output mismatch
  • To update pyyaml version in base.txt for compatible version requirement since to use --lint option, pyyaml > 5.4 is needed
    • Note: since reproducible linux already has pyyaml as 5.4.1, no changes are introduced onto reproducible-linux.txt and THIRD-PARTY-LICENSES

How does it address the issue?

  • Updated the related integration test and verified the tests are passing locally
  • Updated base.txt under requirements folder

What side effects does this change have?

N.A.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qingchm
qingchm requested a review from a team as a code owner December 14, 2022 10:23
@qingchm
qingchm requested review from hawflau and mildaniel December 14, 2022 10:23
mndeveci
mndeveci reviewed Dec 14, 2022
View reviewed changes
Comment thread requirements/base.txt
@mndeveci
mndeveci merged commit ce7143c into aws:develop Dec 14, 2022
@mndeveci
mndeveci deleted the cfnlint-integ branch December 14, 2022 18:40
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 14, 2022
@qingchm @mndeveci
fix: Fix validate command integration tests console output missmatch …
b9b2704 
…and update pyyaml version requirement (aws#4479)

* Update expected validate output message for non-lint scenario

* Update the compatible pyyaml version to be 5.4.1 or above to be compatible with cfn-lint
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 16, 2022
@mndeveci
Revert "fix: Fix validate command integration tests console output mi…
15fbf4b 
…ssmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.
mndeveci added a commit that referenced this pull request Dec 17, 2022
@mndeveci
revert: remove cfn-lint integration (#4494)
42e512d 
* Revert "fix: `hooks` data imports for pyinstaller (#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
f5c9f44 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c3fc28b 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c24af57 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c7b8c56 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawflau hawflau Awaiting requested review from hawflau hawflau was automatically assigned from aws/serverless-application-experience-sbt
@mildaniel mildaniel Awaiting requested review from mildaniel mildaniel was automatically assigned from aws/serverless-application-experience-sbt
2 more reviewers
@mndeveci mndeveci mndeveci approved these changes
@lucashuy lucashuy lucashuy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr/internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qingchm @mndeveci @lucashuy