Skip to content

fix: Update expected message read for ADL sync code watch integration test - #4488

Merged
sriram-mv merged 3 commits into
aws:developfrom
qingchm:adl_watch_integ
Dec 16, 2022
Merged

fix: Update expected message read for ADL sync code watch integration test#4488
sriram-mv merged 3 commits into
aws:developfrom
qingchm:adl_watch_integ

Conversation

@qingchm

@qingchm qingchm commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

Integration test failure on test_sync_adl.TestSyncAdlWithWatchStartWithNoDependencies testMethod=test_sync_watch_code
This is a follow up to #4485

Why is this change necessary?

Since after we change the hash comparison to use the correct permissions, such code syncs should not deploy the ADLs again thus shouldn't trigger Function Layer Reference sync anymore. We need to update the expected output from sync watch.

How does it address the issue?

Updated the expected string

What side effects does this change have?

N.A.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qingchm
qingchm requested a review from a team as a code owner December 15, 2022 10:38
@sriram-mv
sriram-mv enabled auto-merge (squash) December 16, 2022 01:29
@sriram-mv
sriram-mv merged commit abd7c03 into aws:develop Dec 16, 2022
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 16, 2022
@mndeveci
Revert "fix: Update expected message read validate lint integration t…
b73a457 
…est (aws#4488)"

This reverts commit abd7c03.
mndeveci added a commit that referenced this pull request Dec 17, 2022
@mndeveci
revert: remove cfn-lint integration (#4494)
42e512d 
* Revert "fix: `hooks` data imports for pyinstaller (#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (#4444)"

This reverts commit 2fd533f.
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@qingchm @sriram-mv @mndeveci
fix: Update expected message read for ADL sync code watch integration…
fe77015 
… test (aws#4488)

* Update expected message read for adl sync code integration test

* Use OS adaptive path separator for assertions in validate integration tests

Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
f5c9f44 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c3fc28b 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c24af57 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@qingchm @sriram-mv @mndeveci
fix: Update expected message read for ADL sync code watch integration…
7732c9f 
… test (aws#4488)

* Update expected message read for adl sync code integration test

* Use OS adaptive path separator for assertions in validate integration tests

Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c7b8c56 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
@sriram-mv sriram-mv mentioned this pull request Feb 2, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moelasmar moelasmar Awaiting requested review from moelasmar moelasmar was automatically assigned from aws/serverless-application-experience-sbt
4 more reviewers
@sriram-mv sriram-mv sriram-mv approved these changes
@mndeveci mndeveci mndeveci approved these changes
@mildaniel mildaniel mildaniel approved these changes
@hnnasit hnnasit hnnasit approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr/internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qingchm @sriram-mv @mndeveci @mildaniel @hnnasit