Skip to content

Update lint help and output message - #4489

Merged
sriram-mv merged 2 commits into
aws:developfrom
cdavidxu-hub:develop
Dec 16, 2022
Merged

Update lint help and output message#4489
sriram-mv merged 2 commits into
aws:developfrom
cdavidxu-hub:develop

Conversation

@cdavidxu-hub

@cdavidxu-hub cdavidxu-hub commented Dec 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

Update message to include usage of cfnlintrc config files and to avoid assumption of binary name

How does it address the issue?

Removes binary name and includes suggestion for cfnlintrc file

What side effects does this change have?

Changed integration tests

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cdavidxu-hub
cdavidxu-hub requested a review from a team as a code owner December 15, 2022 21:08
@github-actions github-actions Bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. area/validate sam validate command labels Dec 15, 2022
@sriram-mv
sriram-mv merged commit 3304955 into aws:develop Dec 16, 2022
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 16, 2022
@mndeveci
Revert "Update lint helpand output message (aws#4489)"
4cad1a6 
This reverts commit 3304955.
mndeveci added a commit that referenced this pull request Dec 17, 2022
@mndeveci
revert: remove cfn-lint integration (#4494)
42e512d 
* Revert "fix: `hooks` data imports for pyinstaller (#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (#4444)"

This reverts commit 2fd533f.
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@cdavidxu-hub @sriram-mv @mndeveci
Update lint helpand output message (aws#4489)
f8f809d 
Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
f5c9f44 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c3fc28b 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c24af57 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@cdavidxu-hub @sriram-mv @mndeveci
Update lint helpand output message (aws#4489)
bd4b62e 
Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c7b8c56 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingchm qingchm Awaiting requested review from qingchm qingchm was automatically assigned from aws/serverless-application-experience-sbt
@hnnasit hnnasit Awaiting requested review from hnnasit hnnasit was automatically assigned from aws/serverless-application-experience-sbt
2 more reviewers
@sriram-mv sriram-mv sriram-mv approved these changes
@mndeveci mndeveci mndeveci approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/validate sam validate command pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdavidxu-hub @sriram-mv @mndeveci