Skip to content

fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mndeveci merged 2 commits into from
Dec 14, 2022
Merged

fix: Fix validate command integration tests console output missmatch and update pyyaml version requirement #4479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c896c92
Update expected validate output message for non-lint scenario
qingchm Dec 14, 2022
1f9d2f6
Update the compatible pyyaml version to be 5.4.1 or above to be compa…
qingchm Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Werkzeug<2.1
#Need to add Schemas latest SDK.
boto3>=1.19.5,==1.*
jmespath~=0.10.0
PyYAML~=5.3
PyYAML>=5.4.1,==5.*
Comment thread
mndeveci marked this conversation as resolved.
cookiecutter~=2.1.1
aws-sam-translator==1.55.0
#docker minor version updates can include breaking changes. Auto update micro version only.
Expand Down
8 changes: 4 additions & 4 deletions tests/integration/validate/test_validate_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ class TestValidate(TestCase):
def setUpClass(cls):
cls.patterns = {
TemplateFileTypes.JSON: re.compile(
r"template\.json can be transformed to a Cloudformation template."
' Please run "sam validate --lint -t template.yaml" for additional validation(\r\n)?$'
r"template\.json is a valid SAM Template. This is according to basic SAM Validation, "
'for additional validation, please run "sam validate --lint"(\r\n)?$'
),
TemplateFileTypes.YAML: re.compile(
r"template\.yaml can be transformed to a Cloudformation template."
' Please run "sam validate --lint -t template.yaml" for additional validation(\r\n)?$'
r"template\.yaml is a valid SAM Template. This is according to basic SAM Validation, "
'for additional validation, please run "sam validate --lint"(\r\n)?$'
),
}
cls.lint_patterns = {
Expand Down