Add active-workspace-specific fields to Unreported Expenses

[koko57]

Explanation of Change

This PR adds the fields specific to the active workspace to the unreported expenses from selfDM.
If the user has no active workspace, we show Report and Category fields by default and redirect the user to Upgrade when they try editing them.

Fixed Issues

$ #70660
PROPOSAL: -

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

#68988

1. Create a new account
2. Create a workspace
3. Go to the workspace, More Features, and enable Categories, Taxes, and Tags
4. Go to Categories and modify the category list
5. Go to Taxes and modify the Tax rate lists
6. Go to Tags and modify the Tags list
7. Verify that the workspace is the default one for the account
8. Go to selfDM and create a new expense
9. Verify that an actionable whisper from Concierge is created with the options: "Send to someone" and "Do nothing"
10. Click on the newly created expense
11. Verify that the expense has Category, Tag, Tax Rate, Tax Amount, and Report fields
12. Verify that when you click on Category, you are asked to select from the custom list of the workspace categories created at step 4
13. Verify that when you click on Tag, you are asked to select from the custom list of the workspace tags created at step 6
14. Verify that when you click on the Tax Rate, you are asked to select from the custom list of the tax rates created at step 5
15. Verify that updating Category, Tag, Tax Rate, and Tax Amount fields work as expected
16. Click on the Report field and verify that you can either create a new report or select from existing reports linked to the expense chat
17. Create some more unreported expenses in the selfDM chat
18. Go to Reports, select the unreported expenses and verify that you can move them to a report

#68993

1. Create a new account
2. Open the self-DM chat and create a new expense linked to it
3. Verify that an actionable whisper from Concierge is created with the options: "Send to someone" and "Do nothing"
4. Click on the newly created expense
5. Verify that the new expense has the Category field
6. Click on Category and verify that you see the screen with the Upgrade button
7. Click on Upgrade, add workspace name and currency and confirm
8. Verify that you get the screen showing that the workspace was successfully created
9. Click on the Got it button and verify that you have to select a Category from the default Category list

#68994

1. Have an account with an active workspace
2. Go to selfDM and create a new expense
3. Verify that an actionable whisper from Concierge is created with the options: "Send to someone" and "Do nothing"
4. Click on the newly created expense
5. Click on the Report field
6. Verify that you have the option to create a new report
7. Click on that option and verify that the expense is now moved to a new report linked to the active workspace

#68989

1. Create a new account
2. Open the self-DM chat and create a new expense linked to it
3. Verify that an actionable whisper from Concierge is created with the options: "Send to someone" and "Do nothing"
4. Click on the newly created expense
5. Verify that the new expense has the Report field
6. Click on Report and verify that you see the screen with the Upgrade button
7. Click on Upgrade, add workspace name and currency, and confirm
8. Verify that you get the screen showing that the workspace was successfully created
9. Click on the Got it button and verify that you land on a screen with the option to create a new Report
10. Click on the Create new report option and verify that the expense is successfully added to that report

#68995

PREREQUISITES: having an active workspace

1. Have a few unreported expenses
2. Go to Reports and select those with the status: unreported
3. Select all of them and then click on the dropdown with the options for the selected expenses
4. Click on Move expenses option
5. Verify you have the option to create a new report
6. Click on that option and verify that a new report is created on the active workspace and the expenses are successfully moved to that report

#69986

1. Create a workspace (if you don't have one), enable taxes
2. Go to self DM
3. Track a manual expense
4. Open the transaction thread
5. Click Category
6. Select a category
7. Verify that no violation is shown

NOTE: NO violations should be shown until the report is moved to the workspace

#69988

1. Create a workspace (if you don't have one), enable taxes
2. Go to self DM
3. Track a manual expense
4. Open the transaction thread
5. Click Tax
6. Select 5% tax rate
7. Click Tax amount
8. Change amount or just click save/hit enter
9. Verify that "Maximum tax amount is " is not shown
10. Verify that the amount is saved and no error appears

#69989

1. Create a workspace (if you don't have one), enable taxes
2. Go to self DM
3. Track a manual expense
4. Open the transaction thread.
5. Click Category.
6. Select a category.
7. Verify that the system message is: "set the category to [category]"
8. Click Tag.
9. Select a tag.
10. Verify that the system message is: "set the tag to [tag]"
11. Click Tax.
12. Select a tax rate.
13. Verify that the system message is: "set the tax rate to [taxRate]"

#71259

Prerequisites: User is invited to workspace, the invited workspace has disabled Categories, User does not have other workspace.

1. Go to self DM.
2. Create a track expense
3. Open the expense thread
4. The Category field should not be displayed

#71265

Prerequisites: selfDM, at least 1 workspace with no expenses, delayed submissions and approvals enabled.

1. Navigate to Self DM.
2. Turn off internet connection.
3. Create a manual track expense.
4. Open the just created expense.
5. Tap on the report field and select "Create Report"
6. Verify that "Category" field is not missing.
7. Add a merchant and navigate to the workspace where the expense was moved.
8. Verify that the "Submit [amount]" is displayed on expense preview.
9. Turn on internet connection.
10. Open the expense report.
11. Verify that "Category" field is displayed as previously after this action.

#71261

Prerequisites: Account has self DM and a workspace. Delete all workspace categories.

1. Go to self DM
2. Create a track expense
3. Go to expense thread
4. Verify that "Category" field is not displayed

#71252

Prerequisites: Account has self DM and a default workspace.

1. Go to self DM.
2. Create a track expense.
3. Open transaction thread.
4. Click Category and select a category.
5. Go to workspace settings > Categories.
6. Delete the category selected in Step 5.
7. Go back to self DM.
8. Open transaction thread.
9. Verify that you see NO VIOLATION

NOTE: NO violations should be shown until the report is moved to the workspace

#71254

Prerequisites: Account has self DM and a workspace, Taxes are enabled on the workspace.

1. Go to self DM.
2. Create a track expense.
3. Open the expense thread.
4. Click Taxes.
5. Select a tax rate.
6. Click Amount.
7. Change the currency and save it.
8. Verify that the tax rate field shows a complete tax rate name

🚨KNOWN BE ISSUE (fix soon on the prod):
After changing the currency, the tax rate is correctly changed in the optimistic update to the default tax value and the title is displayed correctly, but after the response from the backend it is changed to the old value.

#71255

Prerequisites: Account has self DM and a workspace, Taxes are enabled on the workspace.

1. Go to self DM.
2. Create a track expense.
3. Open the expense thread.
4. Click Category and select a category.
5. Click Taxes.
6. Select Tax Rate 1 (5%).
7. Go back to self DM.
8. Click Submit it to someone.
9. Select the workspace.
10. Verify that the Category and Tax Rates are the same as they were in the expense thread

#71256

Prerequisites: Account has self DM and a default workspace

1. Go to workspace chat
2. Create a distance expense
3. Open the transaction thread
4. Click Report
5. Click Remove from report
6. Go to self DM
7. Open the expense thread
8. Verify that the "Rate not valid for this workspace" violation is not shown on expense preview and in expense thread

#71109

1. Go to workspace chat
2. Create an empty report
3. Go to self DM
4. Track a manual expense
5. Open the transaction thread
6. Click Report field
7. Verify that Report field is clickable as there is an open report

#71274

1. Create a Workspace
2. Create an empty report
3. Open self dm
4. Create a manual track expense
5. Open the expense
6. Verify that the report field displays: "[your name] (you)"

KNOWN ISSUES - will be handled in a follow-up

• the distance rate in the selfDM expense will be different than the one that will be displayed when opening the edit rate page from rate field - in the edit rate page we display available rates on the active workspace, in the transaction thread we have a default rate for selfDM track expense

• billable and reimbursable values for selfDM expense will be false even if the workspace settings default to true

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

Can we please simplify this condition?

[koko57]

what do you propose, I think I simplified a bit?

[parasharrajat]

Started...

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 48 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...es/iou/request/step/IOURequestStepParticipants.tsx	0.00%	9 Missing ⚠️
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	8 Missing ⚠️
...s/iou/request/step/IOURequestStepTaxAmountPage.tsx	0.00%	8 Missing ⚠️
...rc/pages/Search/SearchTransactionsChangeReport.tsx	0.00%	5 Missing ⚠️
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	0.00%	5 Missing ⚠️
...es/iou/request/step/IOURequestStepDistanceRate.tsx	0.00%	4 Missing ⚠️
...es/iou/request/step/IOURequestEditReportCommon.tsx	72.72%	3 Missing ⚠️
...rc/pages/iou/request/step/IOURequestStepReport.tsx	0.00%	2 Missing ⚠️
src/libs/ReportUtils.ts	88.88%	1 Missing ⚠️
src/libs/TransactionUtils/index.ts	66.66%	1 Missing ⚠️
... and 2 more

📢 Thoughts on this report? Let us know!

[koko57]

@parasharrajat I've added the test steps for the whole feature to the Test Steps section, the regressions are all in the QA Steps

[koko57]

@parasharrajat added this one to the fix: #71274

[koko57]

@parasharrajat Ill be available for around two more hours, ping me if you find anything

[parasharrajat]

• Expense- "You haven't created any categories" is shown when member has no access to categories #71259
• Expense - In self dm, Report field is shown blank. #71274
• [Due for payment 2025-10-03] Expense - Report field in track expense is disabled despite having an open report #71109
• [Due for payment 2025-10-15] [Unreported] [$250] [CRITICAL] Bulk move unreported expenses to a new report #68995
• [Unreported] [$250] [CRITICAL] Add upgrade path when user with no active workspace edits the report on an unreported expense #68989
• [Unreported] [$250] [CRITICAL] Add Create Report option when editing Report on unreported expenses in selfDM #68994
• [Unreported] [Payment due][$250] [CRITICAL] Add Category and upgrade path on unreported expenses when the user has no active workspace #68993
• [$250] [CRITICAL] Enable report fields specific to the active workspace for unreported expenses #68988
• [Due for payment 2025-10-06] [Due for payment 2025-10-03] IOU - "Rate not valid for this workspace" is shown on expense preview but missing in expense thread #71256
• Expense - Tax rate and category selected in expense thread is not preserved on confirm page #71255
• [$250] Expense - After changing currency, Tax field is missing tax rate name briefly #71254
• Expense - Category field does not show "Category no longer valid" when category is deleted #71252
• Expense - After importing categories, RHP back button reopens category settings #71261
• Expense -"Submit 0,00" shown and category field missing on track expense moved to new report #71265
• [Due for payment 2025-07-18] [$250] Expense - After moving distance expense to Self DM, "Distance" field is shown as "Pending". #63806

[parasharrajat]

BUG: Create report option is missing from Move expenses on the search expense tab.

26.09.2025_17.38.26_REC.mp4

[parasharrajat]

• [$250] Expense - After changing currency, Tax field is missing tax rate name briefly #71254

No blocker: For , I see that it shows 5% shortly instead of correct name and amount also reset to 0 before switching to actual value.

I think it is out of scope of this project. We can work on it in follow-up.

[koko57]

• [$250] Expense - After changing currency, Tax field is missing tax rate name briefly #71254

No blocker: For , I see that it shows 5% shortly instead of correct name and amount also reset to 0 before switching to actual value.

I think it is out of scope of this project. We can work on it in follow-up.

are you sure? It should be fixed - the only problem is that you first see the optimistic update (default tax rate)and then it goes back to the old value. The BE fix is on the way to the prod

[parasharrajat]

are you sure? It should be fixed - the only problem is that you first see the optimistic update (default tax rate)and then it goes back to the old value. The BE fix is on the way to the prod

Ok, great. Thanks. I mean to say that we don't have to block this PR on this bug.

[parasharrajat]

BUG: On deleting the selected category, error is not show that category is not valid on on the tracked expense.

[koko57]

are you sure? It should be fixed - the only problem is that you first see the optimistic update (default tax rate)and then it goes back to the old value. The BE fix is on the way to the prod

Ok, great. Thanks. I mean to say that we don't have to block this PR on this bug.

@parasharrajat but do you see the whole name or just number%?

[parasharrajat]

just precent e.g 5%

[koko57]

just precent e.g 5%

@parasharrajat if it happens offline - imho not a blocker 😃 and if it also happens offline for the wrokspace expense - not even my fault xD

[parasharrajat]

OK, so I noticed that for some transactions we need to first open them to load. same for reports. Then it works.

[koko57]

@parasharrajat ok, thanks for confirmation! I guess if we want to change it it must be first discussed and done in a separate PR

[parasharrajat]

Sure, I am fine with it. Let's keep this in mind for follow-up. Thanks.

[parasharrajat]

Screenshots

🔲 iOS / native

29.09.2025_23.07.43_REC.mp4

🔲 iOS / Safari

29.09.2025_23.29.04_REC.mp4

🔲 MacOS / Desktop

🔲 MacOS / Chrome

29.09.2025_22.23.55_REC.mp4

🔲 Android / Chrome

🔲 Android / native

29.09.2025_23.55.13_REC.mp4

[parasharrajat]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

[parasharrajat]

Let's tackle the rest of things in follow-up.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.20-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.20-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅