Skip to content

Deploy Checklist: New Expensify 2024-03-12 #38162

Description

@github-actions

Release Version: 1.4.51-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. self-assigned this
    on Mar 12, 2024
  2. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Checking off #32336. This PR was reverted.

  3. OSBotify commented on Mar 12, 2024

    @OSBotify
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.51-0 🚀

  4. kavimuru commented on Mar 12, 2024

    @kavimuru

    #38057 is a PROD PR can we check it off?

  5. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Yes, checked it off, thanks!

  6. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Checking off #38172. Also happens in prod.

  7. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Checking off #38185. Demoted to NAB

  8. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Checking off #38182. Tested the CP on staging and it fixed all blockers it was supposed to.

  9. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Checking off #38183. Demoted to NAB

  10. luacmartins commented on Mar 12, 2024

    @luacmartins
    Contributor

    Checking off #38174. Demoted to NAB

  11. Tony-MK commented on Mar 13, 2024

    @Tony-MK
    Contributor

    Issue #38171 is handled and a fix has been deployed.

    We should presumably check it off. 🤔

  12. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    Checking off #38171. Tested in staging and it's fixed.

  13. mountiny commented on Mar 13, 2024

    @mountiny
    Contributor

    #37998 QAed internally

  14. kavimuru commented on Mar 13, 2024

    @kavimuru

    @luacmartins Regression is down to 8%
    unchecked PRs:
    #37629 failing with #37629
    #37664 failing with #38212 repro in PROD, checking it off
    #37113 failing with #38201
    #37755 failing with #38188 closed with this comment, checking it off
    #38032 web and desktop pending validation and other platforms are pass
    #37595 being validated

  15. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    Checking off #37405. Demoted to NAB

  16. kavimuru commented on Mar 13, 2024

    @kavimuru

    Regression is 2% left in the TR

    unchecked PRs:
    #37629 failing with #37629
    #37113 failing with #38201
    #38032 failing with #38241 and reprod in PROD, cheecking it off

    Open Blockers:
    #38213 and #38214

  17. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    Checking off #37629, since we'll tackle that in #38214.

    @kavimuru is this link correct? #37113 that PR was closed and I don't see it in the checklist

  18. mkhutornyi commented on Mar 13, 2024

    @mkhutornyi
    Contributor

    is this link correct? #37113 that PR was closed and I don't see it in the checklist

    #37713 is the correct PR

  19. kavimuru commented on Mar 13, 2024

    @kavimuru

    @luacmartins, @mkhutornyi was correct, Sorry it was my mistake

  20. tgolen commented on Mar 13, 2024

    @tgolen
    Contributor

    Removed #38213 from being a blocker and checked it off.

  21. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    Ah cool, so I'm checking off #37713 since we confirmed that's the expected behavior, we just need to update the error message.

  22. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    @kavimuru is regression done?

  23. kavimuru commented on Mar 13, 2024

    @kavimuru

    @luacmartins Yes we are done.

  24. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    Checklist is clear. Shipping it

  25. luacmartins commented on Mar 13, 2024

    @luacmartins
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions