[HOLD for payment 2024-03-25] [Wave Collect] [Workflows] "Delayed Submissions" toggle does not toggle off unless backed out for Collect Policy

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.51-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Access staging.new.expensify.com
Sign into a collect policy WS Admin account
Go to workspace setting > Workflows
Toggle ON "Delay Submissions" then attempt to Toggle OFF

Expected Result:

User should be able to Toggle on and off with no problems

Actual Result:

The Toggle off does not work, the user must back out and return to see the toggle turn off

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6411653_1710282341100.User_can_not_toggle_off_Delay_submissions.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@MonilBhavsar

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@MonilBhavsar

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Delayed Submissions" toggle does not toggle off unless backed out for Collect Policy

What is the root cause of that problem?

we always set harvesting.enable = true in optimisticData and after api request complete it return back with the updated value.

App/src/libs/actions/Policy.ts

Lines 436 to 449 in ce3da4e

    
           const optimisticData: OnyxUpdate[] = [ 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, 
        
                   value: { 
        
                       autoReporting: enabled, 
        
                       harvesting: { 
        
                           enabled: true, 
        
                       }, 
        
                       autoReportingFrequency: frequency, 
        
                       pendingFields: {isAutoApprovalEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE}, 
        
                   }, 
        
               }, 
        
           ];

What changes do you think we should make in order to solve the problem?

we need to change harvesting.enable in optimisticData to be based on the toggle button new value

harvesting: {
  // enabled: true, 
  enabled,
},

we need also to reverse it in failureData.

harvesting: {
  enabled: !enabled, 
},

What alternative solutions did you explore? (Optional)

Commented in the offending PR https://github.com/Expensify/App/pull/37441/files#r1522658153

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

The only thing remaining is the payout. This just a note to say that I am OOO now until April 2nd, reassigning a BZ team member to help while I am OOO.

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: #37441
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37441/files#r1522658153
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. No
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal (If the internal engineer determines that we should create a regression test)

Sign into a collect policy WS Admin account
Go to workspace setting > Workflows
Toggle ON "Delay Submissions" then attempt to Toggle OFF
Verify that we can Toggle on and off with no problems

Do we agree 👍 or 👎

@DylanDylann

Okay, so payment summary for this PR as follows:

$500 to @DylanDylann for the fix
$500 to @s77rt for the C+ review

Offers have been sent to you both.

As for the regression test, @lakchote @mountiny do we have a more complete set to pass over to Applause as the project wraps up?

No payment is due for me here. I'm assigned in #37373 where payment will be handled

@DylanDylann

Cool, sounds good. Thanks for declining! @DylanDylann paid!

Navigation Menu

[HOLD for payment 2024-03-25] [Wave Collect] [Workflows] "Delayed Submissions" toggle does not toggle off unless backed out for Collect Policy #38198

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

27 remaining items

Regression Test Proposal (If the internal engineer determines that we should create a regression test)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	autoReporting: enabled,
	harvesting: {
	enabled: true,
	},
	autoReportingFrequency: frequency,
	pendingFields: {isAutoApprovalEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE},
	},
	},
	];

[HOLD for payment 2024-03-25] [Wave Collect] [Workflows] "Delayed Submissions" toggle does not toggle off unless backed out for Collect Policy #38198

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 13, 2024

github-actions commented on Mar 13, 2024

melvin-bot commented on Mar 13, 2024

kavimuru commented on Mar 13, 2024

ahmedGaber93 commented on Mar 13, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

MonilBhavsar commented on Mar 13, 2024

27 remaining items

melvin-bot commented on Mar 21, 2024

zanyrenney commented on Mar 21, 2024

DylanDylann commented on Mar 25, 2024

Regression Test Proposal (If the internal engineer determines that we should create a regression test)

trjExpensify commented on Mar 25, 2024

s77rt commented on Mar 25, 2024

trjExpensify commented on Mar 25, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions