Repository navigation
[HOLD for payment 2024-06-03] [$500] IOU - Creating IOU Distance offline with incomplete addresses results in incorrect error message #38213
Description
Activity
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @lakchote (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.@lakchote I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensifyProduction video
bandicam.2024-03-13.12-56-20-421.mp4
102 remaining items
- changed the title
[-][$500] IOU - Creating IOU Distance offline with incomplete addresses results in incorrect error message[/-][+][HOLD for payment 2024-06-03] [$500] IOU - Creating IOU Distance offline with incomplete addresses results in incorrect error message[/+]on May 27, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-03. 🎊
For reference, here are some details about the assignees on this issue:
- @abdulrahuman5196 requires payment automatic offer (Reviewer)
- @bernhardoj requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
- [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@abdulrahuman5196] Determine if we should create a regression test for this bug.
- [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment Summary:
C+ @abdulrahuman5196 $500 paid in upwork
Contributor @bernhardoj $500 paid in upwork@abdulrahuman5196 please confirm checklist above so we can close this out thanks
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:Not a regression.
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- Open a workspace chat
- Have at least 1 request
- Go offline
- Create a new distance request with invalid waypoints
- Go online
- Open the expense report
- Verify there is an invalid waypoint error message below the money request preview
- Open the transaction thread
- Verify there is an invalid waypoint error message below the distance map image
Reacted by Lauren
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4418303
Email or phone of affected tester (no customers): sustinov@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Preconditions:
Set up an OldDot admin account, invite the employee to the policy https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0
Steps:
Expected Result:
The error "No route found through the waypoints. Please edit the waypoints and try again." Should be shown in the UI.
Actual Result:
The error "Unexpected error requesting money, please try again later" is shown in the UI.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6412058_1710321526582.Recording__1419.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @laurenreidexpensify