[HOLD for payment 2024-03-22] [$500] Authorized payer - Enter key does not select another member as authorized payer

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.51-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

User is an owner of Collect workspace.
There is at least another admin in the workspace.

Go to staging.new.expensify.com.
Go to workspace settings > Collect workspace.
Go to Workflows.
Enable Make or track payments if not enabled.
Click Authorized payer.
Navigate to another admin via keyboard and hit Enter.

Expected Result:

Enter key will select another admin as the authorized payer.

Actual Result:

Enter key is not responsive when the selection is on another admin.
When the selection is on the authorized payer, Enter key exits the RHP.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6411925_1710308620444.bandicam_2024-03-13_13-39-04-261.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cb6806f250da1d85
Upwork Job ID: 1767835771147452416
Last Price Increase: 2024-03-13
Automatic offers:

jjcoffee | Contributor | 0
ishpaul777 | Contributor | 0

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Beamanator

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@Beamanator

@Beamanator FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

The PR that introduced the bug has been identified. Link to the PR: feat: Workflow payer page #37629
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37629/files#r1531725204
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to Workspace settings > Collect workspace.
Go to Workflows.
Enable Make or track payments if not enabled.
Click Authorized payer.
Navigate to another admin via keyboard and hit Enter, verify currect user is Selected as authoirized payer

Do we agree 👍 or 👎

We'll add regression steps once this feature is fully implemented.

@lschurr

@lschurr Friendly bump for payment! 🙇

@jjcoffee

All set! Payment for $500 sent via Upwork to @jjcoffee

@luacmartins

Actually this was a follow up PR, is this eligible for payment @luacmartins

@ishpaul777

Ah it looks like this GH wasn't assigned to you so that's why the offer didn't go out @ishpaul777

@ishpaul777

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ishpaul777

Payment summary:

Contributor: @ishpaul777 $500 (paid in Upwork)
Contributor+: @jjcoffee $500 (paid in Upwork)

Thank you!

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-22] [$500] Authorized payer - Enter key does not select another member as authorized payer #38203

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

30 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-03-22] [$500] Authorized payer - Enter key does not select another member as authorized payer #38203

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 13, 2024

github-actions commented on Mar 13, 2024

melvin-bot commented on Mar 13, 2024

kavimuru commented on Mar 13, 2024

30 remaining items

jjcoffee commented on Mar 20, 2024

luacmartins commented on Mar 20, 2024

jjcoffee commented on Mar 25, 2024

lschurr commented on Mar 25, 2024

ishpaul777 commented on Mar 25, 2024

lschurr commented on Mar 25, 2024

melvin-bot commented on Mar 25, 2024

lschurr commented on Mar 25, 2024

ishpaul777 commented on Mar 25, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions