Repository navigation
[HOLD for payment 2024-04-15] [$500] Start chat - Chat RHP switches to Room tab when dragging input from right to left #38177
Description
Activity
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think that this bug might be related to #vip-vsb
cc @quintharProposal
Please re-state the problem that we are trying to solve in this issue.
Start chat - Chat RHP switches to Room tab when dragging input from right to left
What is the root cause of that problem?
We haven't passed
shouldInterceptSwipeprop totextInput.
What changes do you think we should make in order to solve the problem?
Pass
shouldInterceptSwipeas true. We need to also do it for room description input. We should also check if this occurs somewhere else.
Optionals:- We can do it specifically for
NewChatPage, for that we should acceptshouldInterceptSwipeprop inBaseSelectionListand pass it to the input. - Add
shouldInterceptSwipeto Input as default.
Result
- We can do it specifically for
Offending PR: #34356
Reacted by Francois Laithier71 remaining items
- changed the title
[-][$500] Start chat - Chat RHP switches to Room tab when dragging input from right to left[/-][+][HOLD for payment 2024-04-15] [$500] Start chat - Chat RHP switches to Room tab when dragging input from right to left[/+]on Apr 8, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
- @Santhosh-Sellavel requires payment through NewDot Manual Requests
- @Krishna2323 requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
- [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
- [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payouts due:
- Contributor: $500 @Krishna2323 (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/36827535/overview)
- Contributor+: $500 @Santhosh-Sellavel (payment through NewDot)
Upwork job is here.
@Santhosh-Sellavel Do we need a regression test for this?
No, we would not need a regression test here. This is not something important & its a minor UX polish
Reacted by Christina DobrzynskiBugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
- [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
- [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Reacted by Christina DobrzynskiThis is good to close - payment summary here - #38177 (comment)
Requested on ND
$500 approved for @Santhosh-Sellavel
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.51-0
Reproducible in staging?: y
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:. N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
RHP will not switch to Room tab.
Actual Result:
RHP switches to Room tab when dragging input from right to left.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
description_swipe.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit