Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Add block inserter onboarding tooltip - #3529

Merged
dcalhoun merged 14 commits into
developfrom
add/block-inserter-tooltip
May 27, 2021
Merged

dcalhoun merged 14 commits into
developfrom
add/block-inserter-tooltip

Conversation

@dcalhoun

@dcalhoun dcalhoun commented May 19, 2021 •

Copy link
Copy Markdown
Member

Fixes WordPress/gutenberg#30624. Add tooltip for the block inserter as a part of a larger editor onboarding experience.

To test: See test plan within WordPress/gutenberg#32001.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 19, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun
dcalhoun marked this pull request as ready for review May 20, 2021 22:17
@dcalhoun dcalhoun added this to the 1.54.0 (17.5) milestone May 20, 2021
@dcalhoun
dcalhoun requested a review from jhnstn May 20, 2021 22:20

@jhnstn jhnstn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding Gutenberg PR Approved.

@geriux

geriux commented May 27, 2021

Copy link
Copy Markdown
Contributor

Hey @dcalhoun 👋 Looks like some of the slash inserter tests are not passing with these changes, could you please check them out? Thanks!

@dcalhoun

Copy link
Copy Markdown
Member Author

Hey @dcalhoun 👋 Looks like some of the slash inserter tests are not passing with these changes, could you please check them out? Thanks!

@geriux they appeared to be the same two tests that were failing inconsistently for others as well. I ran them locally and they passed, so I'm not sure if it's a valid failure or flakiness at this time. I have rerun them multiple times on the PR with no success. I will take a deeper look in a couple of hours when I come online for the day. 👍🏻

@geriux

geriux commented May 27, 2021

Copy link
Copy Markdown
Contributor

@geriux they appeared to be the same two tests that were failing inconsistently for others as well. I ran them locally and they passed, so I'm not sure if it's a valid failure or flakiness at this time. I have rerun them multiple times on the PR with no success. I will take a deeper look in a couple of hours when I come online for the day. 👍🏻

I'll double check too 👍

@jhnstn

jhnstn commented May 27, 2021

Copy link
Copy Markdown
Member

Hey @dcalhoun . We will cut the 1.54.0 release later today. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.54.0. Thanks!

@dcalhoun dcalhoun self-assigned this May 27, 2021
@dcalhoun
dcalhoun merged commit d273c9b into develop May 27, 2021
@dcalhoun
dcalhoun deleted the add/block-inserter-tooltip branch May 27, 2021 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add “Tap to add content” tooltip for editor Onboarding Tour

3 participants