Skip to content

Add block inserter onboarding tooltip - #16537

Closed
dcalhoun wants to merge 7 commits into
developfrom
add/block-inserter-tooltip
Closed

dcalhoun wants to merge 7 commits into
developfrom
add/block-inserter-tooltip

Conversation

@dcalhoun

@dcalhoun dcalhoun commented May 19, 2021 •

Copy link
Copy Markdown
Member

Fixes WordPress/gutenberg#30624. Add tooltip for the block inserter as a part of a larger editor onboarding experience.

To test: See test plan within WordPress/gutenberg#32001.

Regression Notes

  1. Potential unintended areas of impact
    Modifications to the Gutenberg block editor could cause the editor to suffer regressions.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Launched the Gutenberg block editor to verify it runs without error.
  3. What automated tests I added (or what prevented me from doing so)
    Did not include automated tests in this work as they would (A) be managed within the Gutenberg project and (B) this feature is an experiment so it may not be worthwhile covering in automated tests at this time.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels May 19, 2021
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 19, 2021 •

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 49085. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 19, 2021 •

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@dcalhoun
dcalhoun marked this pull request as ready for review May 20, 2021 22:17
@dcalhoun dcalhoun added this to the 17.5 milestone May 20, 2021
@dcalhoun
dcalhoun requested a review from jhnstn May 20, 2021 22:20
@AmandaRiu

Copy link
Copy Markdown
Contributor

@dcalhoun Downloaded this build of WPiOS and tested functionality using the steps in this PR. Worked as expected! 👍

@jhnstn jhnstn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gutenberg changes LGTM

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 27, 2021 •

Copy link
Copy Markdown
Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@dcalhoun dcalhoun self-assigned this May 27, 2021
@dcalhoun

Copy link
Copy Markdown
Member Author

Closing this PR as the included changes did not modify bridging code. We also plan to integrate this work with a Gutenberg Mobile release cut later today.

@dcalhoun dcalhoun closed this May 27, 2021
@dcalhoun
dcalhoun deleted the add/block-inserter-tooltip branch May 27, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add “Tap to add content” tooltip for editor Onboarding Tour

3 participants