Repository navigation
Conversation
This was referenced May 19, 2021
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
4 tasks done
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
@dcalhoun pr-14683-wpandroid.mp4 |
…id into add/block-inserter-tooltip
7 tasks done
Member
Author
|
Closing this PR as the included changes did not modify bridging code. We also plan to integrate this work with a Gutenberg Mobile release cut later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WordPress/gutenberg#30624. Add tooltip for the block inserter as a part of a larger editor onboarding experience.
To test: See test plan within WordPress/gutenberg#32001.
Regression Notes
Modifications to the Gutenberg block editor could cause the editor to suffer regressions.
Launched the Gutenberg block editor to verify it runs without error.
Did not include automated tests in this work as they would (A) be managed within the Gutenberg project and (B) this feature is an experiment so it may not be worthwhile covering in automated tests at this time.
PR submission checklist:
RELEASE-NOTES.txtif necessary.