Repository navigation
Avoid unnecessary calculation or animation if tooltip is invisible - #32289
Merged
Merged
Conversation
Previously an animation would run on a invisible tooltip. This resulted in the tooltip being rendered, but invisible, indefinitely. This caused issues for tapping targets rendered beneath the invisible tooltip.
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
jhnstn
approved these changes
May 27, 2021
jhnstn
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Tested on both iOS and Android demo apps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #32001, which contained a bug where animations would run on an invisible tooltip. This resulted in the tooltip being invisibly rendered indefinitely. This caused issues for tapping targets rendered beneath the invisible tooltip.
How has this been tested?
/image.Screenshots
This PR's focus is to address the issue showcased in the video below were the far right side of the first pill for the slash inserter did not register touch events. An invisible tooltip was rendered atop the element block taps.
Before
before.mov
After
after.mov
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).