Skip to content

fix(ci): localize the chat font family search keywords - #33715

Merged
nwparker merged 1 commit into
mainfrom
nwparker/fix-chat-font-l10n
Oct 26, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/fix-chat-font-l10n

Conversation

@nwparker

@nwparker nwparker commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 3 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​16 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​15

ELI5

Main's localization check fails because the new chat font setting (#33687) added search words that are only in English. This makes them translatable like the rest of Settings.

What Changed

  • The chat "Font family" search keywords now use translateSearchKeyword. They reuse the existing "Chat" and "Font family" strings and add two new English strings ("typeface", "typography"), which are indexed alongside the English words.
  • The fontFamily text in the font preview is a CSS property name shown as code, so it's added to the localization allowlist as a reviewed exclusion.

Verified

  • verify:localization-coverage, -catalogs, -catalog, -runtime-catalog and -extraction all pass.
  • pnpm tc:web, oxlint and oxfmt are clean.
  • Settings tests pass (256 files, 1828 tests).

#33687 added English-only search keywords and a code sample to the chat font
setting, which fails main's localization coverage check.
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9ba1381e-e10d-42d2-b49b-f6d6f2444cbb
Commits

Reviewing files that changed from the base of the PR and between bd2f463 and 28ab1f0.

Files selected for processing: 3
  • config/localization-coverage-allowlist.json
  • src/renderer/src/components/settings/chat-appearance-search.ts
  • src/renderer/src/i18n/locales/en.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The font-family search keyword list now uses localized Chat and Font family labels, plus localized typeface and typography keywords. English translations were added for typeface and typography. The localization coverage allowlist now includes an entry for the fontFamily text in ChatFontFamilySetting.tsx.

Priority: Normal

Merge Risk: Minimal · up to 28ab1

The localized font search changes are mergeable with no identified production or workflow risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem, user-facing change, implementation, and verification results. However, it omits required template sections, including the linked issue, visual proof or an explici… Add the required template sections. Provide a linked issue, add before-and-after visual proof or state N/A with a reason, document testing under the Testing heading, and complete the applicable checklist items.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: localizing the chat font family search keywords.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description explains the problem, user-facing change, implementation, and verification results. However, it omits required template sections, including the linked issue, visual proof or an explicit N/A explanation, and the Testing and Checklist sections.

Resolution

Add the required template sections. Provide a linked issue, add before-and-after visual proof or state N/A with a reason, document testing under the Testing heading, and complete the applicable checklist items.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit 5dfaee0 into main Oct 26, 2026
32 checks passed
audichuang pushed a commit to audichuang/orca that referenced this pull request Oct 26, 2026
stablyai#33687 added English-only search keywords and a code sample to the chat font
setting, which fails main's localization coverage check.

(cherry picked from commit 5dfaee0)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
audichuang added a commit to audichuang/orca that referenced this pull request Oct 26, 2026
…33715

The cherry-picked upstream fix adds two en.json keys that upstream has not
translated yet; fork-locale-parity counts them as fork keys until a release
carries them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
audichuang added a commit to audichuang/orca that referenced this pull request Oct 27, 2026
…33715

The cherry-picked upstream fix adds two en.json keys that upstream has not
translated yet; fork-locale-parity counts them as fork keys until a release
carries them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
audichuang added a commit to audichuang/orca that referenced this pull request Oct 28, 2026
…33715

The cherry-picked upstream fix adds two en.json keys that upstream has not
translated yet; fork-locale-parity counts them as fork keys until a release
carries them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant