Skip to content

fix(i18n): localize chat font search metadata - #33710

Closed
OrcaWin wants to merge 1 commit into
mainfrom
fix/audit-ci-chat-font-localization
Closed

OrcaWin wants to merge 1 commit into
mainfrom
fix/audit-ci-chat-font-localization

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Superseded by #33715, now merged on main. It localizes the same chat font search synonyms through the existing keyword helper and excludes the literal CSS identifier. Closing this duplicate; the test-audit PRs will rebase onto the upstream fix.

The corrected local candidate passed full renderer localization coverage, formatting/lint, and the existing current-main search case. The earlier candidate’s dropped typeface alias was caught by CI and corrected before closure.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b2aa770-cb41-47e4-b022-81594f1e4ce9
Commits

Reviewing files that changed from the base of the PR and between bd2f463 and b0de583120106be15bd276b4ca7134fb426be938.

Files selected for processing: 2
  • config/localization-coverage-allowlist.json
  • src/renderer/src/components/settings/chat-appearance-search.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The font-family search entry now uses the translated “Chat” title as its keyword. The localization coverage allowlist marks the fontFamily text as non-dynamic, with a count of one and a reason identifying it as a CSS property token that should not be translated.

Priority: Normal

Merge Risk: Minimal · up to b0de5

The change is limited to localized chat search metadata and its coverage allowlist; it is ready to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains that this PR is superseded and should close, but it does not follow the repository template. It omits ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing checklist de… If this PR remains open, replace the description with the required template and complete all applicable sections, including the linked issue and testing details. If the PR is intentionally obsolete, close it and reference the superseding PR…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: localizing chat font search metadata and the related internationalization fix.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains that this PR is superseded and should close, but it does not follow the repository template. It omits ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing checklist details, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist sections.

Resolution

If this PR remains open, replace the description with the required template and complete all applicable sections, including the linked issue and testing details. If the PR is intentionally obsolete, close it and reference the superseding PR #33715 in the closure instead of merging it.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin force-pushed the fix/audit-ci-chat-font-localization branch from b0de583 to 8805629 Compare October 26, 2026 00:55
@OrcaWin OrcaWin closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant