Repository navigation
Conversation
Contributor
Author
|
Superseded by #33715, which fixed the same main localization failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainfails Verify localization coverage. #33687 added untranslated settings-search keywords inchat-appearance-search.ts(chat,font,family,typeface,typography) and a<code>fontFamily</code>literal inChatFontFamilySetting.tsx. Every PR branched frommaincurrently fails static analysis because of this.Fix
translateSearchKeyword/translate, the same way the other settings search catalogs do, and each locale gets new keys undersettings.appearance.chat.keywords.fontFamilyis the CSS property name shown in the font preview, so it's added to the localization allowlist rather than translated.Test
verify:localization-coverage,verify:localization-catalogs,verify:localization-extractionandpnpm check:changedall pass.