Skip to content

test: strengthen Git and session assertions; remove copied pathspec replay - #33669

Merged
OrcaWin merged 1 commit into
mainfrom
audit/test-value-425
Oct 26, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
audit/test-value-425

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Strengthens Git and session assertions and removes one copied pathspec replay. Reviews 48 sources: 299 authored declarations → 298 (288 kept, ten repaired, one removed), with seven changed test files.

Formatting, configured lint, and fresh full CI passed. CI ran 46 standalone unit suites plus the Git compatibility cases and the consumer of an unchanged zero-case fixture. The merged change preserves the selected tests and reviewed owners; a separately reviewed upstream change to an observed test remains qualified rather than claimed as executed by this CI run.

Merged; audit tracker and evidence cache published. Four obsolete Darwin-build suites removed upstream receive no new audit credit.

@OrcaWin
OrcaWin force-pushed the audit/test-value-425 branch from 55a6fb2 to fae1897 Compare October 25, 2026 23:05
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7153b586-0356-4eed-9aca-e5049a30b55d
Commits

Reviewing files that changed from the base of the PR and between 55a6fb2f502255bcb681fabe6671d6179b66475e and fae1897.

Files selected for processing: 2
  • src/main/native-chat/agent-session-wire/structured-agent-session-host-test-data.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-startup-attempt-host.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The changes update tests across workflow, session scanning, Git utilities, and shared modules. They add session cutoff cases and an explicit workflow-step existence check. They replace a Git path-partition test oracle with expected results and adjust fixture selection. Other changes revise test descriptions or fixture naming without changing the described test logic. Shared send and cancel parameter factories now provide test inputs for the startup-attempt host test.

Priority: Low

Merge Risk: Minimal · up to fae18

No actionable merge-blocking risk is established by these test-only changes.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 10 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Warning The description explains the main test changes and reports validation, but it does not follow the required template. It omits the required section headings, explicit issue link, visual-proof statement… Rewrite the description using all required template sections. Add an actual linked issue under “Linked Issue” (use “Fixes #33715” only if that issue is the intended target), state “N/A” with a reason under “Visual Proof,” document testing a…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title accurately summarizes the main changes: stronger Git and session test assertions and removal of the copied pathspec replay.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the main test changes and reports validation, but it does not follow the required template. It omits the required section headings, explicit issue link, visual-proof statement, testing checklist, AI disclosure, review notes, boundary declaration, and final checklist.

Resolution

Rewrite the description using all required template sections. Add an actual linked issue under “Linked Issue” (use “Fixes #33715” only if that issue is the intended target), state “N/A” with a reason under “Visual Proof,” document testing and platform coverage, complete the AI Disclosure section, address review and compatibility notes, and mark the applicable checklist items.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin force-pushed the audit/test-value-425 branch from a492626 to 6df5dee Compare October 26, 2026 00:58
@OrcaWin
OrcaWin merged commit c6f8d70 into main Oct 26, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant