Skip to content

fix(desktop): keep annotation comment direction independent of host page #11005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Oct 11, 2026
Merged

fix(desktop): keep annotation comment direction independent of host page #11005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0967483
fix(desktop): keep annotation comment direction independent of host page
abdelrhmanehab10 Sep 9, 2026
f418b92
Merge branch 'main' into fix/rtl-annotation-comment-4644
maria-rcks Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/desktop/src/preview/PickPreload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ function startAnnotation(sendEnabled: boolean): void {
let finished = false;
const host = document.createElement("div");
host.setAttribute(OVERLAY_ATTRIBUTE, "");
host.setAttribute("dir", "ltr");
host.style.cssText = `position:fixed;inset:0;z-index:${Z_INDEX_OVERLAY};pointer-events:none`;
applyAnnotationTheme(host, annotationTheme);
const shadowRoot = host.attachShadow({ mode: "closed" });
Expand All @@ -563,6 +564,7 @@ function startAnnotation(sendEnabled: boolean): void {

const root = document.createElement("div");
root.setAttribute(OVERLAY_ATTRIBUTE, "");
root.setAttribute("dir", "ltr");
root.className = "fixed inset-0 font-sans text-foreground";
root.style.cssText = "pointer-events:none";
const cursorStyle = document.createElement("style");
Expand Down Expand Up @@ -612,6 +614,7 @@ function startAnnotation(sendEnabled: boolean): void {

const comment = document.createElement("textarea");
comment.placeholder = "Describe the change…";
comment.setAttribute("dir", "auto");
comment.rows = 1;
comment.className =
"min-h-8 max-h-24 min-w-0 flex-1 resize-none overflow-y-hidden border-0 border-b border-b-transparent bg-transparent px-0 py-1.5 font-sans text-sm leading-5 text-foreground outline-none ring-0 placeholder:text-muted-foreground focus:border-b-primary focus:outline-none focus:ring-0";
Expand Down
Loading