Conversation
- get rid of `[vuex] unknown mutation type: policies/SET_POLICIES` error by importing the whole policies module and then overriding only values that are needed for a test - remove tests that were prone to giving false positives and weren't testing responsibilities of PolicyModals component
- user props and events in simpler modal components (PoliciesModal, TermsOfServiceModal, PrivacyPolicyModal, CommunityStandardsModal) to decouple them from store to make logic simpler and easier to test - related tests simplifications of PoliciesModal - related updates of store and PolicyModals component that is now the only controller component encapsulating all Vuex logic - some more tests for PoliciesModal nad PolicyModals
- export getters, mutations, and actions to allow testing them directly instead of the need to initialize the whole store, similarly to how we test getters etc. of our other store modules (this has also allowed deletion of mocks that are not related to this test suite) - use hardcoded sample data in tests to improve clarity and make orientation in tests faster when reading them as documentation - add more documentation strings to store functions - move the test for updating `window.user` object to plugin.spec.js to make sure that `window.user` will be updated every time `setPolicies` mutation is called, and not only when `setPolicies` is called from `acceptPolicy` action
`KModal`'s content slot is already wrapped in form => leaving `VForm` here would result in nested forms, which is not supported and could result in bugs (see https://stackoverflow.com/questions/379610/can-you-nest-html-forms). - remove `VForm` - replace `Checkbox` with `KCheckbox` (related to `VForm` deletion in terms of validation logic) - update validation logic to resemble `VForm`'s behaviour but to work with `KCheckbox` and native `<form>` in `KModal`
Because `PolicyModals` was in both `UsingStudio` and `SettingsIndex` components, it was open two times which also caused a focus bug. This removes `PolicyModals` component from `UsingStudio` and leaves it only in `SettingsIndex`.
…ciesmodal KDS to Studio: Use KModal in policy modals
Production into unstable
Delete deployed squashed migrations. Remove tests for removed migrations. Remove some deprecated calls.
Upgrade to django 3.1
Pagination integration proof of concept
Add Brazilian Portuguese
Hotfixes release for sprint ending 2021-05-24
Fixes two Django 1.11 to 3.2 upgrade issues in search.
Fixes two Django 1.11 to 3.2 upgrade issues in search.
Fix password reset for Django 3.2 upgrade
Load portuguese country name data for country listing
Redirects using a reverse URL rather than hardcoded 'channels'
Call DISTINCT after filtering queryset by ids from pagination
Sprint release 2021-05-24 strings
rtibbles
approved these changes
Jun 2, 2021
radinamatic
approved these changes
Jun 2, 2021
Member
radinamatic
left a comment
radinamatic
left a comment
There was a problem hiding this comment.
hotfixes tested (thank you, @pcenov) and the new strings look OK, let's do this! 👍🏽
bjester
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary