Upgrade to django 3.2#2533
Conversation
Codecov Report
@@ Coverage Diff @@
## unstable #2533 +/- ##
============================================
- Coverage 86.13% 84.82% -1.31%
============================================
Files 305 182 -123
Lines 16455 15034 -1421
============================================
- Hits 14173 12753 -1420
+ Misses 2282 2281 -1
Continue to review full report at Codecov.
|
|
As this is a huge change in terms of requirements, could you take a look at #2236 to see if you can include some of the changes from there, so we'd be hitting two targets with one shot? with its associated dependencies. |
|
Can do, that seems in line with the big dependency shift! |
jredrejo
left a comment
There was a problem hiding this comment.
Tested with python 3.8 and everything seems to work fine... but when clicking on a channel to open its edit modal, I get quite often this error trace:
"HEAD /api/contentnode/ce5297fa2c5247529b9bcc68eec77d97 HTTP/1.1" 200 1067
INFO:django.server:"HEAD /api/contentnode/ce5297fa2c5247529b9bcc68eec77d97 HTTP/1.1" 200 1067
----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 56004)
Traceback (most recent call last):
File "/usr/lib/python3.8/socketserver.py", line 650, in process_request_thread
self.finish_request(request, client_address)
File "/usr/lib/python3.8/socketserver.py", line 360, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python3.8/socketserver.py", line 720, in __init__
self.handle()
File "/datos/le/studio/venv/lib/python3.8/site-packages/django/core/servers/basehttp.py", line 171, in handle
self.handle_one_request()
File "/datos/le/studio/venv/lib/python3.8/site-packages/django/core/servers/basehttp.py", line 179, in handle_one_request
self.raw_requestline = self.rfile.readline(65537)
File "/usr/lib/python3.8/socket.py", line 669, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [Errno 104] Connection reset by peer
----------------------------------------
But, from an user point of view, nothing happens, everything seems correct in the browser. Also, it's very seldom, editing the same channel a few minutes later does not raise this error.
I have checked the original url being INFO:django.server:"GET /channels/05436ac33a2d41e1ac600dfdf0e14835/ HTTP/1.1" 200 111499
and the browser network tab shows

so it seems the application self-recovers from the problem
7f9942d to
634637d
Compare
5e9051d to
d26a854
Compare
jredrejo
left a comment
There was a problem hiding this comment.
Everything works perfectly after the requirements*txt files are regenerated (current ones have some minor problems with python 3.8, but with pip-compile requirements.in it's solved) . This is not a fault from this PR but from the https://github.com/rtibbles/studio/blob/django2.2/README.md file , it should say it before executing the pip install -r requirements.txt command.
In that case we could change this README.md to say that this works with Python 3.6-3.8
965fad5 to
f8a51d9
Compare
Delete deployed squashed migrations. Remove tests for removed migrations. Remove some deprecated calls.
Description