Skip to content

Fix password reset for Django 3.2 upgrade#3174

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles:password_reset
May 27, 2021
Merged

Fix password reset for Django 3.2 upgrade#3174
rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles:password_reset

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Copies latest URLs path from Django 3.2

Manual verification steps performed

  1. Attempt to request reset password link
  2. Navigate to reset password link
  3. Reset password

References

Fixes #3173

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested review from bjester and marcellamaki May 27, 2021 15:40
@rtibbles rtibbles changed the base branch from unstable to hotfixes May 27, 2021 15:48
Copy link
Copy Markdown
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and manual QA working ✔️

@rtibbles rtibbles merged commit 78e547e into learningequality:hotfixes May 27, 2021
@rtibbles rtibbles deleted the password_reset branch May 27, 2021 17:17
@pcenov
Copy link
Copy Markdown
Member

pcenov commented May 28, 2021

Tested and verified as fixed at hotfixes.studio.learningequality.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password reset failiure

3 participants