Skip to content

Redirects using a reverse URL rather than hardcoded 'channels'#3177

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:lang_redirect
May 27, 2021
Merged

Redirects using a reverse URL rather than hardcoded 'channels'#3177
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:lang_redirect

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Our redirect after login was hard coded to '/channels' which caused it to redirect to the default language, English, after login
  • The only thing I am confused by is how this ever worked

Manual verification steps performed

  1. Switch to a non-English language on the sign in page
  2. Sign in
  3. Be redirected to Channels in your chosen language

Screenshots (if applicable)

Screenshot from 2021-05-27 10-44-37

References

Fixes #3169

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested review from bjester and nucleogenesis May 27, 2021 17:45
@rtibbles rtibbles added bug P0 - critical Priority: Release blocker or regression TAG: regression labels May 27, 2021
@rtibbles rtibbles changed the base branch from unstable to hotfixes May 27, 2021 17:46
@bjester bjester merged commit d1527bd into learningequality:hotfixes May 27, 2021
@pcenov
Copy link
Copy Markdown
Member

pcenov commented May 28, 2021

Tested and verified as fixed at hotfixes.studio.learningequality.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug P0 - critical Priority: Release blocker or regression TAG: regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The interface language defaults to English after I sign in

3 participants