Skip to content

Add MindManager as a macOS FMA - #46906

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-mindmanager-fma
Jun 5, 2026
Merged

Add MindManager as a macOS FMA#46906
allenhouchins merged 1 commit into
mainfrom
allenhouchins-mindmanager-fma

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jun 5, 2026

Copy link
Copy Markdown
Member

Introduce MindManager to the maintained apps set: add a Homebrew input (mindmanager.json), register the app in ee/maintained-apps/outputs/apps.json, and provide a darwin versions file for v25.2.105 including installer URL, sha256, and install/uninstall script refs. Also add a frontend SVG icon component, wire it into the icon map, and include the 2x PNG asset. These changes enable the app to be detected, installed/uninstalled, and displayed in the UI.

Summary by CodeRabbit

  • New Features
    • Added support for MindManager on macOS with automatic installation and uninstallation capabilities.
    • MindManager now appears in the application catalog with its visual icon for easy identification.

Introduce MindManager to the maintained apps set: add a Homebrew input (mindmanager.json), register the app in ee/maintained-apps/outputs/apps.json, and provide a darwin versions file for v25.2.105 including installer URL, sha256, and install/uninstall script refs. Also add a frontend SVG icon component, wire it into the icon map, and include the 2x PNG asset. These changes enable the app to be detected, installed/uninstalled, and displayed in the UI.
@allenhouchins allenhouchins linked an issue Jun 5, 2026 that may be closed by this pull request
@allenhouchins allenhouchins changed the title Add MindManager app metadata and icon Add MindManager as a macOS FMA Jun 5, 2026
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.02%. Comparing base (41b3b53) to head (1ca188f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/SoftwarePage/components/icons/MindManager.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46906      +/-   ##
==========================================
- Coverage   67.02%   67.02%   -0.01%     
==========================================
  Files        2859     2860       +1     
  Lines      224683   224685       +2     
  Branches    11577    11577              
==========================================
+ Hits       150592   150593       +1     
- Misses      60445    60446       +1     
  Partials    13646    13646              
Flag Coverage Δ
frontend 56.93% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review June 5, 2026 15:35
@allenhouchins
allenhouchins requested a review from a team as a code owner June 5, 2026 15:35
Copilot AI review requested due to automatic review settings June 5, 2026 15:35
@fleet-release
fleet-release requested a review from eashaw June 5, 2026 15:35

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit 6e2256f into main Jun 5, 2026
29 of 30 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-mindmanager-fma branch June 5, 2026 15:35
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e1992e2-3227-4d01-bd6a-c937171cdde1

📥 Commits

Reviewing files that changed from the base of the PR and between ceb743d and 1ca188f.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-mindmanager-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • ee/maintained-apps/inputs/homebrew/mindmanager.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/mindmanager/darwin.json
  • frontend/pages/SoftwarePage/components/icons/MindManager.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds MindManager as a Fleet-maintained application on macOS. It introduces a Homebrew input definition specifying the app metadata (identifier, installer format as DMG, slug), a macOS installation manifest with version 25.2.105 including presence queries and embedded bash scripts for installing and uninstalling, registers the app in the apps catalog with its unique identifier and platform, and adds a React icon component with UI integration for the software page.

Possibly related issues

  • New FMA: MindManager #46755: Implements the requested Fleet-maintained app (FMA) for MindManager by adding the Homebrew input, installation manifest, apps registry entry, and UI icon.

Possibly related PRs

  • fleetdm/fleet#46429: Adds another maintained app with parallel structure—Homebrew input, installation manifest, apps registry update, and SOFTWARE_NAME_TO_ICON_MAP extension.
  • fleetdm/fleet#46337: Follows the same macOS maintained-app pattern (homebrew input + darwin.json manifest + apps.json + icon registration).
  • fleetdm/fleet#46250: Adds a new software icon and updates SOFTWARE_NAME_TO_ICON_MAP with the same frontend registration pattern.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-mindmanager-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MindManager to Fleet’s maintained apps catalog for macOS, including the maintained-app metadata (inputs/outputs), install/uninstall scripts, and a corresponding UI icon so the app can be detected and displayed consistently in the Software UI.

Changes:

  • Add Homebrew input manifest and register MindManager in the maintained apps index (apps.json).
  • Add MindManager macOS (darwin) versions definition with detection queries, installer URL, sha256, and install/uninstall script refs.
  • Add a new frontend icon component and wire it into the software-name-to-icon map.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/MindManager.tsx Adds MindManager icon component (base64 PNG-in-SVG pattern consistent with existing icons).
frontend/pages/SoftwarePage/components/icons/index.ts Registers the new icon and maps the mindmanager software name key to it.
ee/maintained-apps/outputs/mindmanager/darwin.json Defines MindManager macOS version metadata, detection queries, installer URL/checksum, and install/uninstall scripts.
ee/maintained-apps/outputs/apps.json Registers MindManager in the maintained apps list for discovery/selection.
ee/maintained-apps/inputs/homebrew/mindmanager.json Adds the Homebrew input definition for generating/maintaining the MindManager app entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New FMA: MindManager

3 participants