Skip to content

Add ClickShare as a macOS FMA - #47016

Merged
allenhouchins merged 1 commit into
mainfrom
46760-new-fma-clickshare
Jun 7, 2026
Merged

Add ClickShare as a macOS FMA#47016
allenhouchins merged 1 commit into
mainfrom
46760-new-fma-clickshare

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jun 7, 2026

Copy link
Copy Markdown
Member

Add ClickShare to maintained apps and frontend. Creates a Homebrew input (ee/maintained-apps/inputs/homebrew/clickshare.json), adds an apps.json entry, and adds an outputs file for darwin with version 4.50.0 (installer URL, sha256, and install/uninstall script refs). Also adds a React SVG icon component, registers it in the icon map, and includes the 60x60@2x PNG asset for the app. Default category set to Communication.

Summary by CodeRabbit

New Features

  • Added support for ClickShare application on macOS with installation and uninstallment capabilities
  • Added ClickShare icon to the application interface for improved visual identification

Add ClickShare to maintained apps and frontend. Creates a Homebrew input (ee/maintained-apps/inputs/homebrew/clickshare.json), adds an apps.json entry, and adds an outputs file for darwin with version 4.50.0 (installer URL, sha256, and install/uninstall script refs). Also adds a React SVG icon component, registers it in the icon map, and includes the 60x60@2x PNG asset for the app. Default category set to Communication.
@allenhouchins allenhouchins linked an issue Jun 7, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.04%. Comparing base (21e42c0) to head (a995596).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pages/SoftwarePage/components/icons/ClickShare.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #47016      +/-   ##
==========================================
- Coverage   67.04%   67.04%   -0.01%     
==========================================
  Files        2871     2872       +1     
  Lines      225125   225127       +2     
  Branches    11742    11600     -142     
==========================================
+ Hits       150928   150929       +1     
- Misses      60527    60528       +1     
  Partials    13670    13670              
Flag Coverage Δ
frontend 56.97% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review June 7, 2026 02:42
@allenhouchins
allenhouchins requested a review from a team as a code owner June 7, 2026 02:42
Copilot AI review requested due to automatic review settings June 7, 2026 02:42
@fleet-release
fleet-release requested a review from eashaw June 7, 2026 02:42

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit 6fb22c0 into main Jun 7, 2026
29 of 30 checks passed
@allenhouchins
allenhouchins deleted the 46760-new-fma-clickshare branch June 7, 2026 02:42
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 74b5b36f-65eb-4905-8abb-baa44ec4527e

📥 Commits

Reviewing files that changed from the base of the PR and between 21e42c0 and a995596.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-clickshare-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • ee/maintained-apps/inputs/homebrew/clickshare.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/clickshare/darwin.json
  • frontend/pages/SoftwarePage/components/icons/ClickShare.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds ClickShare as a Fleet-managed macOS application. It defines ClickShare in the Homebrew input configuration and app registry, establishes macOS update logic (version 4.50.0) with embedded shell scripts for installation and uninstallation that handle app lifecycle and file management, and provides a React icon component integrated into the frontend icon registry for UI display.

Possibly related issues

  • #46760: This PR directly implements the ClickShare Homebrew cask integration with matching token, installer format (zip), and macOS app entry requested in the issue.

Possibly related PRs

  • fleetdm/fleet#45883: Adds a different app icon to the same SOFTWARE_NAME_TO_ICON_MAP registry in frontend/pages/SoftwarePage/components/icons/index.ts.
  • fleetdm/fleet#46906: Follows the same pattern of adding a new macOS maintained-app entry and extending the SOFTWARE_NAME_TO_ICON_MAP registry with a new software-name-to-icon mapping.
  • fleetdm/fleet#45858: Adds a new macOS app definition and extends the shared icon registry with a corresponding icon component in the same way.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 46760-new-fma-clickshare

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ClickShare as a Fleet-maintained app (macOS/Homebrew) and wires up its icon so it renders properly in the Software UI.

Changes:

  • Adds a Homebrew maintained-app input and generated macOS output manifest for ClickShare (v4.50.0), including install/uninstall script refs and category.
  • Registers ClickShare in the maintained apps catalog (apps.json) so it’s discoverable as an FMA.
  • Adds a ClickShare icon component and maps the ClickShare name to that icon in the Software page icon registry.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/index.ts Imports and registers the ClickShare icon in the name→icon map.
frontend/pages/SoftwarePage/components/icons/ClickShare.tsx Adds the ClickShare SVG icon component (embedded PNG data).
ee/maintained-apps/outputs/clickshare/darwin.json Adds the generated maintained-app output (queries, installer URL/SHA, install/uninstall scripts, categories).
ee/maintained-apps/outputs/apps.json Adds ClickShare to the maintained apps catalog list.
ee/maintained-apps/inputs/homebrew/clickshare.json Adds the Homebrew input definition for ClickShare.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New FMA: ClickShare

3 participants