Add macOS Fleet-maintained apps (Q) - #47304
Conversation
Adds 5 Fleet-maintained app(s) whose cask token starts with 'Q': inputs, outputs, app icons (TSX + website PNG), and the matching index.ts and apps.json entries. Split out from #47121.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #47304 +/- ##
==========================================
- Coverage 67.19% 67.19% -0.01%
==========================================
Files 3147 3151 +4
Lines 227025 227035 +10
Branches 11741 11890 +149
==========================================
+ Hits 152545 152551 +6
- Misses 60739 60742 +3
- Partials 13741 13742 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove all maintained-app entries and related frontend assets for Qobuz. This deletes the Homebrew input (qobuz.json), the darwin output manifest and installer scripts, the apps.json entry, the Qobuz React SVG icon and its image asset, and the reference to Qobuz in the icons index. The bundle identifier removed was com.qobuz.QobuzDesktop.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (14)
WalkthroughThis PR onboards four macOS applications (QLab, sbarex QLMarkdown, QSpace Pro, and qView) through the maintained-apps pipeline. It adds input metadata definitions for each app, generates installation and uninstallation manifests with embedded Bash scripts for version detection and app lifecycle management, updates the app registry, and provides React icon components with frontend name-to-icon registration for the SoftwarePage UI. Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds new macOS Fleet-maintained apps whose Homebrew cask tokens start with “q”, including their maintained-app manifests and corresponding software icons so Fleet’s Software UI can display app-specific icons.
Changes:
- Added Fleet-maintained app input definitions (Homebrew) and generated output manifests (darwin) for qlab, qlmarkdown, qspace-pro, and qview.
- Added new base64-embedded icon components and wired them into the Software icon name-to-icon map.
- Appended the new apps to the maintained apps catalog (
apps.json).
Reviewed changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/Qview.tsx | Adds qView icon component. |
| frontend/pages/SoftwarePage/components/icons/QspacePro.tsx | Adds QSpace Pro icon component. |
| frontend/pages/SoftwarePage/components/icons/Qlmarkdown.tsx | Adds QLMarkdown icon component. |
| frontend/pages/SoftwarePage/components/icons/Qlab.tsx | Adds QLab icon component. |
| frontend/pages/SoftwarePage/components/icons/index.ts | Registers the new icons and maps software names to icon components. |
| ee/maintained-apps/outputs/qview/darwin.json | Adds generated maintained-app manifest + scripts for qView (macOS). |
| ee/maintained-apps/outputs/qspace-pro/darwin.json | Adds generated maintained-app manifest + scripts for QSpace Pro (macOS). |
| ee/maintained-apps/outputs/qlmarkdown/darwin.json | Adds generated maintained-app manifest + scripts for QLMarkdown (macOS). |
| ee/maintained-apps/outputs/qlab/darwin.json | Adds generated maintained-app manifest + scripts for QLab (macOS). |
| ee/maintained-apps/outputs/apps.json | Adds the new apps to the maintained apps catalog list. |
| ee/maintained-apps/inputs/homebrew/qview.json | Adds Homebrew input metadata for qView. |
| ee/maintained-apps/inputs/homebrew/qspace-pro.json | Adds Homebrew input metadata for QSpace Pro. |
| ee/maintained-apps/inputs/homebrew/qlmarkdown.json | Adds Homebrew input metadata for QLMarkdown. |
| ee/maintained-apps/inputs/homebrew/qlab.json | Adds Homebrew input metadata for QLab. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "QLab", | ||
| "slug": "qlab/darwin", | ||
| "platform": "darwin", | ||
| "unique_identifier": "com.figure53.QLab.5", | ||
| "description": "QLab is a sound, video and lighting control." | ||
| }, |
| { | ||
| "name": "sbarex QLMarkdown", | ||
| "slug": "qlmarkdown/darwin", | ||
| "platform": "darwin", | ||
| "unique_identifier": "org.sbarex.QLMarkdown", | ||
| "description": "sbarex QLMarkdown is a quick Look generator for Markdown files." | ||
| }, |
Adds 5 Fleet-maintained app(s) whose cask token starts with 'Q': inputs, outputs, app icons (TSX + website PNG), and the matching index.ts and apps.json entries.
Summary by CodeRabbit