Skip to content

Add macOS Fleet-maintained apps (Q) - #47304

Merged
allenhouchins merged 3 commits into
mainfrom
new-mac-fmas-q
Jun 10, 2026
Merged

Add macOS Fleet-maintained apps (Q)#47304
allenhouchins merged 3 commits into
mainfrom
new-mac-fmas-q

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jun 10, 2026

Copy link
Copy Markdown
Member

Adds 5 Fleet-maintained app(s) whose cask token starts with 'Q': inputs, outputs, app icons (TSX + website PNG), and the matching index.ts and apps.json entries.

Summary by CodeRabbit

  • New Features
    • Added support for four new macOS applications: QLab (v5.5.10), QLMarkdown (v1.5.1), QSpace Pro (v6.2.2), and qView (v7.1). Each includes complete installation and uninstallation management, automatic version detection, and personalized application icons for seamless integration.

Adds 5 Fleet-maintained app(s) whose cask token starts with 'Q':
inputs, outputs, app icons (TSX + website PNG), and the matching
index.ts and apps.json entries. Split out from #47121.
fleet-release
fleet-release previously approved these changes Jun 10, 2026
fleet-release
fleet-release previously approved these changes Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.19%. Comparing base (cd4d45f) to head (f1f0981).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ntend/pages/SoftwarePage/components/icons/Qlab.tsx 50.00% 1 Missing ⚠️
...pages/SoftwarePage/components/icons/Qlmarkdown.tsx 50.00% 1 Missing ⚠️
.../pages/SoftwarePage/components/icons/QspacePro.tsx 50.00% 1 Missing ⚠️
...tend/pages/SoftwarePage/components/icons/Qview.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #47304      +/-   ##
==========================================
- Coverage   67.19%   67.19%   -0.01%     
==========================================
  Files        3147     3151       +4     
  Lines      227025   227035      +10     
  Branches    11741    11890     +149     
==========================================
+ Hits       152545   152551       +6     
- Misses      60739    60742       +3     
- Partials    13741    13742       +1     
Flag Coverage Δ
frontend 57.85% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Remove all maintained-app entries and related frontend assets for Qobuz. This deletes the Homebrew input (qobuz.json), the darwin output manifest and installer scripts, the apps.json entry, the Qobuz React SVG icon and its image asset, and the reference to Qobuz in the icons index. The bundle identifier removed was com.qobuz.QobuzDesktop.
@allenhouchins
allenhouchins marked this pull request as ready for review June 10, 2026 15:23
@allenhouchins
allenhouchins requested a review from a team as a code owner June 10, 2026 15:23
Copilot AI review requested due to automatic review settings June 10, 2026 15:23
@fleet-release
fleet-release requested a review from eashaw June 10, 2026 15:23
@allenhouchins
allenhouchins merged commit 4b6e494 into main Jun 10, 2026
29 of 31 checks passed
@allenhouchins
allenhouchins deleted the new-mac-fmas-q branch June 10, 2026 15:23
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: abd99ebb-3da0-4ce7-abf7-cf44a6e3d743

📥 Commits

Reviewing files that changed from the base of the PR and between cd4d45f and f1f0981.

⛔ Files ignored due to path filters (4)
  • website/assets/images/app-icon-qlab-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-qlmarkdown-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-qspace-pro-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-qview-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (14)
  • ee/maintained-apps/inputs/homebrew/qlab.json
  • ee/maintained-apps/inputs/homebrew/qlmarkdown.json
  • ee/maintained-apps/inputs/homebrew/qspace-pro.json
  • ee/maintained-apps/inputs/homebrew/qview.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/qlab/darwin.json
  • ee/maintained-apps/outputs/qlmarkdown/darwin.json
  • ee/maintained-apps/outputs/qspace-pro/darwin.json
  • ee/maintained-apps/outputs/qview/darwin.json
  • frontend/pages/SoftwarePage/components/icons/Qlab.tsx
  • frontend/pages/SoftwarePage/components/icons/Qlmarkdown.tsx
  • frontend/pages/SoftwarePage/components/icons/QspacePro.tsx
  • frontend/pages/SoftwarePage/components/icons/Qview.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR onboards four macOS applications (QLab, sbarex QLMarkdown, QSpace Pro, and qView) through the maintained-apps pipeline. It adds input metadata definitions for each app, generates installation and uninstallation manifests with embedded Bash scripts for version detection and app lifecycle management, updates the app registry, and provides React icon components with frontend name-to-icon registration for the SoftwarePage UI.

Possibly related PRs

  • fleetdm/fleet#47010: Extends the maintained-apps pipeline by adding new macOS app entries (inputs/outputs JSON with installer/uninstaller scripts) and updates the frontend icon map.
  • fleetdm/fleet#47018: Adds new maintained-app entries and extends the shared app registry and icon mappings.
  • fleetdm/fleet#46906: Extends the maintained-app pipeline with new macOS app definitions and registers a new software-to-icon mapping in the frontend.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new-mac-fmas-q

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new macOS Fleet-maintained apps whose Homebrew cask tokens start with “q”, including their maintained-app manifests and corresponding software icons so Fleet’s Software UI can display app-specific icons.

Changes:

  • Added Fleet-maintained app input definitions (Homebrew) and generated output manifests (darwin) for qlab, qlmarkdown, qspace-pro, and qview.
  • Added new base64-embedded icon components and wired them into the Software icon name-to-icon map.
  • Appended the new apps to the maintained apps catalog (apps.json).

Reviewed changes

Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/Qview.tsx Adds qView icon component.
frontend/pages/SoftwarePage/components/icons/QspacePro.tsx Adds QSpace Pro icon component.
frontend/pages/SoftwarePage/components/icons/Qlmarkdown.tsx Adds QLMarkdown icon component.
frontend/pages/SoftwarePage/components/icons/Qlab.tsx Adds QLab icon component.
frontend/pages/SoftwarePage/components/icons/index.ts Registers the new icons and maps software names to icon components.
ee/maintained-apps/outputs/qview/darwin.json Adds generated maintained-app manifest + scripts for qView (macOS).
ee/maintained-apps/outputs/qspace-pro/darwin.json Adds generated maintained-app manifest + scripts for QSpace Pro (macOS).
ee/maintained-apps/outputs/qlmarkdown/darwin.json Adds generated maintained-app manifest + scripts for QLMarkdown (macOS).
ee/maintained-apps/outputs/qlab/darwin.json Adds generated maintained-app manifest + scripts for QLab (macOS).
ee/maintained-apps/outputs/apps.json Adds the new apps to the maintained apps catalog list.
ee/maintained-apps/inputs/homebrew/qview.json Adds Homebrew input metadata for qView.
ee/maintained-apps/inputs/homebrew/qspace-pro.json Adds Homebrew input metadata for QSpace Pro.
ee/maintained-apps/inputs/homebrew/qlmarkdown.json Adds Homebrew input metadata for QLMarkdown.
ee/maintained-apps/inputs/homebrew/qlab.json Adds Homebrew input metadata for QLab.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3077 to +3083
{
"name": "QLab",
"slug": "qlab/darwin",
"platform": "darwin",
"unique_identifier": "com.figure53.QLab.5",
"description": "QLab is a sound, video and lighting control."
},
Comment on lines +3084 to +3090
{
"name": "sbarex QLMarkdown",
"slug": "qlmarkdown/darwin",
"platform": "darwin",
"unique_identifier": "org.sbarex.QLMarkdown",
"description": "sbarex QLMarkdown is a quick Look generator for Markdown files."
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants