Skip to content

Add PlugData as a macOS FMA - #46337

Merged
allenhouchins merged 1 commit into
fleetdm:mainfrom
desmonet:fma/plugdata
May 28, 2026
Merged

Add PlugData as a macOS FMA#46337
allenhouchins merged 1 commit into
fleetdm:mainfrom
desmonet:fma/plugdata

Conversation

@desmonet

@desmonet desmonet commented May 28, 2026

Copy link
Copy Markdown
Contributor

Addition of PlugData to the Fleet-Maintained apps list.

Product information: https://plugdata.org/
Homebrew formula: https://formulae.brew.sh/cask/plugdata#default

Thanks!

@allenhouchins

Summary by CodeRabbit

  • New Features
    • Added PlugData application support for macOS, enabling version 0.9.3 installation
    • PlugData app icon integrated into the interface for visual identification and easy discovery

Review Change Stack

@desmonet
desmonet requested a review from a team as a code owner May 28, 2026 14:52

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.89%. Comparing base (7c33552) to head (a1225a8).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...d/pages/SoftwarePage/components/icons/Plugdata.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46337      +/-   ##
==========================================
- Coverage   66.89%   66.89%   -0.01%     
==========================================
  Files        2782     2783       +1     
  Lines      221734   221736       +2     
  Branches    11356    11356              
==========================================
+ Hits       148334   148335       +1     
- Misses      59999    60000       +1     
  Partials    13401    13401              
Flag Coverage Δ
frontend 56.28% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request adds PlugData as a new managed application to Fleet. The backend layer defines PlugData metadata in homebrew format, registers it in the application list for the darwin platform, and includes macOS-specific installer and uninstaller logic with bash scripts that handle app lifecycle (quit/relaunch) and package receipt cleanup. The frontend layer introduces a React icon component embedding a base64-encoded PNG and wires it into the software icon registry for UI display.

Possibly related PRs

  • fleetdm/fleet#45858: Extends SOFTWARE_NAME_TO_ICON_MAP and adds corresponding app definitions in apps.json for a different application.
  • fleetdm/fleet#46264: Adds a new maintained-app entry and registers its icon by updating SOFTWARE_NAME_TO_ICON_MAP and apps.json.
  • fleetdm/fleet#46250: Adds new software entries and icons by extending SOFTWARE_NAME_TO_ICON_MAP with corresponding app metadata and installer manifests.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. While it explains the change (adding PlugData to the Fleet-Maintained apps list), it does not follow the required template structure with checklists for validation, testing, database migrations, and other compliance items. Fill out the required checklist template from the repository, including sections for input validation, testing, database migrations, and fleetd/orbit compatibility as applicable to this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'Add PlugData as a macOS FMA' clearly and concisely summarizes the main change: adding the PlugData application to the Fleet-Maintained apps (FMA) list for macOS, which is directly reflected in the file changes across homebrew metadata, app outputs, icon components, and registry updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@allenhouchins allenhouchins changed the title Added PlugData to FMA Add PlugData as a macOS FMA May 28, 2026
@allenhouchins

Copy link
Copy Markdown
Member

@desmonet thanks for the contribution!

@allenhouchins
allenhouchins merged commit d313300 into fleetdm:main May 28, 2026
23 of 24 checks passed
This was referenced May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants