Windows FMA - Prisma Browser - #46409
Merged
Merged
Conversation
harrisonravazzolo
temporarily deployed
to
Docker Hub
May 28, 2026 23:43 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46409 +/- ##
==========================================
- Coverage 66.87% 66.87% -0.01%
==========================================
Files 2787 2788 +1
Lines 222285 222287 +2
Branches 11297 11297
==========================================
+ Hits 148663 148664 +1
- Misses 60167 60168 +1
Partials 13455 13455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds Prisma Browser as a maintained application: a winget input manifest, a registry entry in apps.json, Windows installer metadata (version 148.18.4.217) with embedded PowerShell install/uninstall scripts and installer URL/SHA-256/upgrade code, and a new Prisma React SVG icon component wired into SOFTWARE_NAME_TO_ICON_MAP for UI rendering. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
frontend/pages/SoftwarePage/components/icons/Prisma.tsx (1)
5-13: 🏗️ Heavy liftOptional: Replace Prisma’s embedded base64 PNG with SVG paths for better scaling and bundle size.
frontend/pages/SoftwarePage/components/icons/Prisma.tsxembeds a raster PNG via<image href="data:image/png;base64,...">, which won’t scale cleanly and adds base64 payload cost. Repo-wide, this pattern is common (228 icon files embed base64 PNGs), while only a small subset uses SVG paths (<path>appears in 36 files), so converting Prisma to paths would be an incremental quality/perf improvement rather than aligning with the dominant icon style.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/pages/SoftwarePage/components/icons/Prisma.tsx` around lines 5 - 13, The Prisma component currently embeds a raster PNG via the <image href="data:image/png;base64,..."> inside the Prisma functional component (Prisma) which prevents crisp scaling and inflates bundle size; replace the embedded base64 image with vector SVG path elements (or import an optimized .svg and inline its path(s)) inside the same <svg> element, preserve forwarding of SVGProps<SVGSVGElement> (keep the Prisma props spread), add an appropriate viewBox and remove/adjust fixed width/height if necessary so the icon scales, and ensure the final JSX uses <path> (and related SVG primitives) instead of <image href=...>.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/apps.json`:
- Line 1717: The description string currently reads "Prisma Browser is an
SASE-native browser that empowers secure work." but uses the wrong article;
update the description value in the apps.json entry (the JSON object containing
the "description" key shown) to "Prisma Browser is a SASE-native browser that
empowers secure work." so the indefinite article matches the pronunciation of
"SASE".
---
Nitpick comments:
In `@frontend/pages/SoftwarePage/components/icons/Prisma.tsx`:
- Around line 5-13: The Prisma component currently embeds a raster PNG via the
<image href="data:image/png;base64,..."> inside the Prisma functional component
(Prisma) which prevents crisp scaling and inflates bundle size; replace the
embedded base64 image with vector SVG path elements (or import an optimized .svg
and inline its path(s)) inside the same <svg> element, preserve forwarding of
SVGProps<SVGSVGElement> (keep the Prisma props spread), add an appropriate
viewBox and remove/adjust fixed width/height if necessary so the icon scales,
and ensure the final JSX uses <path> (and related SVG primitives) instead of
<image href=...>.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e201ef60-0485-49d7-a12a-e72e1be59686
⛔ Files ignored due to path filters (1)
website/assets/images/app-icon-prisma-60x60@2x.pngis excluded by!**/*.png
📒 Files selected for processing (5)
ee/maintained-apps/inputs/winget/prisma-browser.jsonee/maintained-apps/outputs/apps.jsonee/maintained-apps/outputs/prisma-browser/windows.jsonfrontend/pages/SoftwarePage/components/icons/Prisma.tsxfrontend/pages/SoftwarePage/components/icons/index.ts
fleet-release
approved these changes
May 29, 2026
allenhouchins
approved these changes
May 29, 2026
This was referenced May 29, 2026
Merged
This was referenced Jun 5, 2026
3 tasks
allenhouchins
added a commit
that referenced
this pull request
Jul 21, 2026
**Related issue:** Resolves #49328 Adds Prisma Access Browser (Homebrew cask `prisma-access-browser`) as a macOS Fleet-maintained app. ## Notes for reviewers **Naming/slug:** This product already ships as a Windows FMA named **Prisma Browser** (`prisma-browser/windows`, added in #46409 — "Prisma Browser" is Palo Alto's current branding for what was Prisma Access Browser). The FMA library combines platforms into one row by slug token, so this entry uses `name: "Prisma Browser"` and `slug: "prisma-browser/darwin"` while keeping `token: "prisma-access-browser"` for the cask lookup (same token≠slug pattern as the `libreoffice`, `ollama`, and `zoom` inputs). Both platforms now show as a single "Prisma Browser" library row and share the existing Prisma icon, so no icon changes are needed. **Identity verified against the real installer** (downloaded the full pkg; SHA256 matches the cask): - `CFBundleIdentifier` = `com.talon-sec.Work` (from the pkg Distribution/PackageInfo), so the exists query matches osquery's `apps` table. - `CFBundleShortVersionString` = `150.49.5.129`, exactly the cask version before the comma, so the patched query's `bundle_short_version` comparison reconciles. - Installs `Prisma Access Browser.app` machine-wide to `/Applications` as root; requires macOS 12+. Not a bootstrapper. **Install script filename:** the cask's pkg artifact (`PrismaBrowser-universal.pkg`) doesn't match the URL basename, but the vendor serves that name via `Content-Disposition`, which is what the server stores (`FilenameFromResponse`) and what orbit names the downloaded installer on both download paths — so the auto-generated install script works without a custom script. **Installer URL** is pinned (version + hash in the path), so no latest-redirect SHA-drift risk. # Checklist for submitter ## Testing - [x] Verified installer identity fields (bundle ID, versions, SHA256) against the real pkg - [x] `go test ./ee/maintained-apps/... ./cmd/maintained-apps/...` passes; generated JSON validated - [ ] FMA validator run (CI) confirms install/uninstall on a macOS host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Style / UI