Skip to content

Add BlueJ as a Windows FMA - #46222

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-bluej-windows-fma
May 26, 2026
Merged

Add BlueJ as a Windows FMA#46222
allenhouchins merged 1 commit into
mainfrom
allenhouchins-bluej-windows-fma

Conversation

@allenhouchins

@allenhouchins allenhouchins commented May 26, 2026

Copy link
Copy Markdown
Member

Add BlueJ as a maintained Windows app: new winget input manifest (ee/maintained-apps/inputs/winget/bluej.json), PowerShell install and uninstall scripts (ee/maintained-apps/inputs/winget/scripts/bluej_install.ps1 and bluej_uninstall.ps1), and output metadata (ee/maintained-apps/outputs/bluej/windows.json). Also update apps index (ee/maintained-apps/outputs/apps.json) to include BlueJ. The install script passes ALLUSERS=2 so the per-user WiX MSI installs per-machine when run elevated; the uninstall script finds related product codes for the app's upgrade code and uninstalls each with a timeout. The outputs include version 5.5.0, installer URL, checksum, and embedded script refs.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added BlueJ application support with Windows installation and uninstallation capabilities
    • BlueJ icon now displays in the software interface

Review Change Stack

Add BlueJ as a maintained Windows app: new winget input manifest (ee/maintained-apps/inputs/winget/bluej.json), PowerShell install and uninstall scripts (ee/maintained-apps/inputs/winget/scripts/bluej_install.ps1 and bluej_uninstall.ps1), and output metadata (ee/maintained-apps/outputs/bluej/windows.json). Also update apps index (ee/maintained-apps/outputs/apps.json) to include BlueJ. The install script passes ALLUSERS=2 so the per-user WiX MSI installs per-machine when run elevated; the uninstall script finds related product codes for the app's upgrade code and uninstalls each with a timeout. The outputs include version 5.5.0, installer URL, checksum, and embedded script refs.
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.83%. Comparing base (36720fb) to head (899b6e2).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tend/pages/SoftwarePage/components/icons/Bluej.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46222      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%     
==========================================
  Files        2756     2757       +1     
  Lines      220200   220202       +2     
  Branches    10916    11043     +127     
==========================================
+ Hits       147171   147172       +1     
- Misses      59736    59737       +1     
  Partials    13293    13293              
Flag Coverage Δ
frontend 55.79% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review May 26, 2026 20:37
@allenhouchins
allenhouchins requested a review from a team as a code owner May 26, 2026 20:37
Copilot AI review requested due to automatic review settings May 26, 2026 20:37
@fleet-release
fleet-release requested a review from eashaw May 26, 2026 20:37

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit 48ace11 into main May 26, 2026
28 of 29 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-bluej-windows-fma branch May 26, 2026 20:37
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c305eb0d-dd90-439c-aae4-c01f75c95c0d

📥 Commits

Reviewing files that changed from the base of the PR and between 36720fb and 899b6e2.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-bluej-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • ee/maintained-apps/inputs/winget/bluej.json
  • ee/maintained-apps/inputs/winget/scripts/bluej_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/bluej_uninstall.ps1
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/bluej/windows.json
  • frontend/pages/SoftwarePage/components/icons/Bluej.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This pull request adds BlueJ application support to Fleet's maintained apps system. It introduces a Winget input manifest with PowerShell scripts for silent MSI installation and uninstallation, creates output configuration metadata including version information and embedded script references, and adds a React icon component to the frontend for UI display. The input scripts manage elevated installation with the ALLUSERS=2 parameter and uninstallation via Windows Installer COM objects with timeout handling, while the output configuration links these scripts and provides detection queries for installation state.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-bluej-windows-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants