Skip to content

FMA - Another Redis Desktop Manager - #46495

Merged
allenhouchins merged 5 commits into
mainfrom
fma-redis-desktop
May 30, 2026
Merged

FMA - Another Redis Desktop Manager#46495
allenhouchins merged 5 commits into
mainfrom
fma-redis-desktop

Conversation

@harrisonravazzolo

@harrisonravazzolo harrisonravazzolo commented May 29, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added support for Another Redis Desktop Manager with full install, update, and uninstall flows for macOS (DMG) and Windows, including silent install/uninstall behavior and version detection.
    • Integrated app icon and branding across the UI for clear identification and smoother user experience.

Review Change Stack

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.81%. Comparing base (ef6a51d) to head (fa25f4b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ge/components/icons/AnotherRedisDesktopManager.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46495      +/-   ##
==========================================
- Coverage   66.81%   66.81%   -0.01%     
==========================================
  Files        2805     2807       +2     
  Lines      223576   223580       +4     
  Branches    11481    11346     -135     
==========================================
+ Hits       149380   149382       +2     
- Misses      60640    60643       +3     
+ Partials    13556    13555       -1     
Flag Coverage Δ
frontend 56.48% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/inputs/homebrew/another-redis-desktop-manager.json

ERROR: Could not retrieve previous version of file (file may not exist in previous commit)

ee/maintained-apps/outputs/another-redis-desktop-manager/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/another-redis-desktop-manager/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

@harrisonravazzolo
harrisonravazzolo marked this pull request as ready for review May 29, 2026 23:54
@harrisonravazzolo
harrisonravazzolo requested a review from a team as a code owner May 29, 2026 23:54

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/inputs/homebrew/another-redis-desktop-manager.json

ERROR: Could not retrieve previous version of file (file may not exist in previous commit)

ee/maintained-apps/outputs/another-redis-desktop-manager/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/another-redis-desktop-manager/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 33939fea-05b6-4bd1-9925-adb8a4d26264

📥 Commits

Reviewing files that changed from the base of the PR and between 2e36c76 and fa25f4b.

📒 Files selected for processing (1)
  • ee/maintained-apps/inputs/homebrew/another-redis-desktop-manager.json

Walkthrough

This pull request adds comprehensive support for the "Another Redis Desktop Manager" application across Fleet's macOS and Windows platforms. It includes Homebrew and Winget package manager input definitions, platform-specific PowerShell scripts for Windows installation and uninstallation, generated distribution manifests with embedded scripts, registration in the app catalog, and a new frontend React icon component with wiring to the application icon map.

Possibly related PRs

  • fleetdm/fleet#45404: Also adds an app icon mapping to SOFTWARE_NAME_TO_ICON_MAP in the same frontend component.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely empty, missing all required sections from the template including related issues, checklist items, testing details, and other critical information. Add a comprehensive pull request description following the repository template, including related issue number, completed checklist items, testing approach, and any relevant notes about the FMA implementation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: adding support for Another Redis Desktop Manager application through the FMA (Fleet Maintained Apps) system.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-redis-desktop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/inputs/homebrew/another-redis-desktop-manager.json`:
- Line 7: Update the default_categories value for the package manifest so it
matches the Winget classification: replace the current "Security" entry in the
default_categories array with "Developer tools" in the JSON manifest (look for
the "default_categories" key and the current "Security" value in
another-redis-desktop-manager.json) to ensure consistent cross-platform
categorization for the GUI Redis client.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3be2414a-2410-4dd5-bb1b-52cc1bbf3104

📥 Commits

Reviewing files that changed from the base of the PR and between ef6a51d and 2e36c76.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-another-redis-desktop-manager-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (9)
  • ee/maintained-apps/inputs/homebrew/another-redis-desktop-manager.json
  • ee/maintained-apps/inputs/winget/another-redis-desktop-manager.json
  • ee/maintained-apps/inputs/winget/scripts/another-redis-desktop-manager_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/another-redis-desktop-manager_uninstall.ps1
  • ee/maintained-apps/outputs/another-redis-desktop-manager/darwin.json
  • ee/maintained-apps/outputs/another-redis-desktop-manager/windows.json
  • ee/maintained-apps/outputs/apps.json
  • frontend/pages/SoftwarePage/components/icons/AnotherRedisDesktopManager.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Comment thread ee/maintained-apps/inputs/homebrew/another-redis-desktop-manager.json Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@allenhouchins
allenhouchins merged commit ffb9d87 into main May 30, 2026
17 of 18 checks passed
@allenhouchins
allenhouchins deleted the fma-redis-desktop branch May 30, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants